Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thoroughly test FractionInputIsEquivalentToRuleClassifier #1892

Closed
Sarthak2601 opened this issue Sep 24, 2020 · 2 comments · Fixed by #2024
Closed

Thoroughly test FractionInputIsEquivalentToRuleClassifier #1892

Sarthak2601 opened this issue Sep 24, 2020 · 2 comments · Fixed by #2024
Assignees
@peculiaruc
Labels
good first issue This item is good for new contributors to make their pull request. Hacktoberfest This is a suggested Hacktoberfest issue. Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Sarthak2601
Copy link
Contributor

Sarthak2601 commented Sep 24, 2020 •
edited by rt4914
Loading

Since the FractionInputIsEquivalentToRuleClassifier was copied from Oppia web, it didn't have corresponding tests added to verify correctness. These should be ported over from Oppia web as well to ensure that each classifier has working functionality.

Useful reference - https://github.com/oppia/oppia-android/tree/develop/domain/src/test/java/org/oppia/android/domain/classify/rules
@Sarthak2601 Sarthak2601 added Type: Improvement Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. good first issue This item is good for new contributors to make their pull request. labels Sep 24, 2020
@Sarthak2601 Sarthak2601 added this to the Backlog milestone Sep 24, 2020
@Sarthak2601 Sarthak2601 mentioned this issue Sep 24, 2020
Closed
29 tasks
@BenHenning BenHenning added the Hacktoberfest This is a suggested Hacktoberfest issue. label Oct 1, 2020
@peculiaruc
Copy link
Contributor

peculiaruc commented Oct 14, 2020 •
edited
Loading

I am working on this already

@peculiaruc peculiaruc mentioned this issue Oct 19, 2020
Merged
8 tasks
@peculiaruc
Copy link
Contributor

peculiaruc commented Oct 20, 2020 •
edited
Loading

@rt4914 PTAL.
My lint checks are failing but I have intended my codes correctly, please advice

rt4914 pushed a commit that referenced this issue Oct 29, 2020
@peculiaruc
Fix #1892: Format FractionInputIsEquivalentToRuleClassifier (#2024)
ec2524c 
* {{Fix #1892: Thoroughly test FractionInputIsEquivalentToRuleClassifier}}

* {{Fix #1892: Thoroughly test FractionInputIsEquivalentToRuleClassifier}}

* {{Fix #1892: Thoroughly test FractionInputIsEquivalentToRuleClassifier}}

* {{Fix #1892: Thoroughly test FractionInputIsEquivalentToRuleClassifier}}

* {{Fix #1892: Thoroughly test FractionInputIsEquivalentToRuleClassifier}}

* {{Fix #1892: Thoroughly test FractionInputIsEquivalentToRuleClassifier}}

* {{Fixes #1892: Thoroughly test FractionInputIsEquivalentToRuleClassifier
}}

* {{Fixes #1892: Thoroughly test FractionInputIsEquivalentToRuleClassifier}}

* {{Fixes #1892: Thoroughly test FractionInputIsEquivalentToRuleClassifier}}

* {{Fixes #1892: Thoroughly test FractionInputIsEquivalentToRuleClassifier}}

* {{Fixes #1892: Thoroughly test FractionInputIsEquivalentToRuleClassifier}}

* {{Fixes #1892: Format FractionInputIsEquivalentToRuleClassifier}}

* {{Fixes #1892: Format FractionInputIsEquivalentToRuleClassifier}}

* Test Updated

* Test updated

* Unnecessary functions removed

* Unnecessary functions removed

* Additional text added

* Typos Corrected

* Typos Corrected

* Removed TODO

* Lines updated

Co-authored-by: pecpaker <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peculiaruc peculiaruc

Labels
good first issue This item is good for new contributors to make their pull request. Hacktoberfest This is a suggested Hacktoberfest issue. Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1892: Format FractionInputIsEquivalentToRuleClassifier
3 participants
@BenHenning @peculiaruc @Sarthak2601