-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimise code in profile_chooser_profile_view.xml #1957
Comments
Hi! I am interested in this but please can you attach the screenshot to this issue |
Welcome to Oppia, @peculiaruc! |
please can you assign the issue to me |
@peculiaruc Rajat has already assigned it to you. |
Do you have an easier one you might refer me to please
…On Sat, 10 Oct 2020, 4:16 PM Mohamed Medhat, ***@***.***> wrote:
@peculiaruc <https://github.com/peculiaruc> Rajat has already assigned it
to you.
Please note that this issue requires more work and it can take some time.
I suggest that you start working on something easier if you want to get
more points quickly, but if you want to work on this to learn new concepts,
of course you can do.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1957 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIOVAV253W6M4Y55DDUAHG3SKB3F7ANCNFSM4SI35IUA>
.
|
Have a look at #1954 |
@rt4914 PTAL |
This issue is tracking the optimization work of
profile_chooser_profile_view.xml
Make sure that the layout uses
ConstraintLayout
and there is minimal nesting of views. If this view already usesConstraintLayout
then it's fine.Make sure that all TextViews use the style from
styles.xml
file likeHeading1
,TextFieldLabel
,Body
, etc. whichever suits best.While making the above changes the UI should not get affected and the end result should still be the same as before (or an optimized version of UI).
If there are multiple files with the same name, update them all.
References
Mobile Portrait: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/grid/
Mobile Landscape: https://xd.adobe.com/view/ee9e607b-dbd6-4372-48dc-b687d32af3da-98af/grid/
Tablet: https://xd.adobe.com/view/d405de00-a871-4f0f-73a0-f8acef30349b-a234/grid/
Wiki: https://github.com/oppia/oppia-android/wiki/Working-on-UI
The text was updated successfully, but these errors were encountered: