Fix #1957: Optimise code in profile_chooser_profile_view.xml

[peculiaruc]

Explanation

Fixes #1957: Flatten the view hierarchy to use ConstraintLayout and minimal nesting of views and made sure that all TextViews uses the style from styles.xml

Checklist

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
• The PR follows the style guide.
• The PR does not contain any unnecessary auto-generated code from Android Studio.
• The PR is made from a branch that's not called "develop".
• The PR is made from a branch that is up-to-date with "develop".
• The PR's branch is based on "develop" and not on any other branch.
• The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

[peculiaruc]

@rt4914 PTAL

[anandwana001]

Few initial points:

1. PR Title Fix #bugnum: Optimise code in profile_chooser_profile_view.xml
2. The issue specified in the PR description is already closed. Please correct the issue number.
3. Always do Reformat Code from the menu toolbar. Our Wiki Guide - https://github.com/oppia/oppia-android/wiki/Ktlint-Guide#macros

[peculiaruc]

@anandwana001 I have treated 1 & 2. Implemented 3 before pushing but let me do that again

[peculiaruc]

Done.

[rt4914]

@peculiaruc Thanks for the PR.

The changes in this PR does not match with previous implementation.

The best way to test such PRs is by comparing screenshots.

1. In latest develop, take screenshots under various circumstances for mobile+tablet in landscape and portrait orientation.
2. Then apply your changes and in your branch, re-run the app and take screenshots in similar circumstances for mobile+tablet in landscape and portrait orientation.
3. Now compare these screenshots and you will find the issues.

Thanks.

[rt4914]

Also couple of points related to PR:

1. Your branch name should be all-small characters. Like: optimise_profile_chooser_profile_view_codes
2. Please use Assignees and Reviewers section from now on in your PRs. https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section

[peculiaruc]

@peculiaruc Thanks for the PR.

The changes in this PR does not match with previous implementation.

The best way to test such PRs is by comparing screenshots.

1. In latest develop, take screenshots under various circumstances for mobile+tablet in landscape and portrait orientation.
2. Then apply your changes and in your branch, re-run the app and take screenshots in similar circumstances for mobile+tablet in landscape and portrait orientation.
3. Now compare these screenshots and you will find the issues.

Thanks.

Noted. Thanks

[peculiaruc]

Also couple of points related to PR:

1. Your branch name should be all-small characters. Like: optimise_profile_chooser_profile_view_codes
2. Please use Assignees and Reviewers section from now on in your PRs. https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section

Done.

@rt4914 PTAL at PR #2089, I updated my branch name for PR #2068, As I push my code it automatically asked for a new PR. Hope that's okay.

[rt4914]

@peculiaruc you can close this PR if not needed.

[peculiaruc]

@peculiaruc you can close this PR if not needed.

Done