Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1957: Optimise code in profile_chooser_profile_view.xml #2100

Merged
merged 2 commits into from
Nov 12, 2020
Merged

Fix #1957: Optimise code in profile_chooser_profile_view.xml #2100

merged 2 commits into from
Nov 12, 2020

Conversation

peculiaruc
Copy link
Contributor

@peculiaruc peculiaruc commented Nov 9, 2020 •
edited
Loading

Explanation

Fix #1957: Flatten the view hierarchy to use ConstraintLayout and minimal nesting of views and made sure that all TextViews uses the style from styles.xml.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@peculiaruc peculiaruc requested a review from rt4914 November 9, 2020 22:20
@peculiaruc peculiaruc assigned peculiaruc and rt4914 and unassigned peculiaruc Nov 9, 2020
rt4914
rt4914 approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @peculiaruc

@rt4914 rt4914 merged commit 6dbde25 into oppia:develop Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimise code in profile_chooser_profile_view.xml
2 participants
@peculiaruc @rt4914