Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1593: Landscape support for Hints & Solution #1615

Merged
merged 7 commits into from
Aug 15, 2020

Conversation

anandwana001
Copy link
Contributor

@anandwana001 anandwana001 commented Aug 11, 2020

Explanation

Fix #1593

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anandwana001 This PR solves the crash issue but there is still on big issue.

  1. Once you reach the Hints screen, click on Reveal, now change to landscape, you will notice below screen:
    Screenshot_1597214343

  2. Also, make sure that above error is fixed for Solution also, meaning similar to Hints there is one Solution button also which comes when all hints are finished. Solution is present in below mentioned screen:
    Screenshot_1597214533
    Screenshot_1597214619

@rt4914 rt4914 assigned anandwana001 and unassigned rt4914 Aug 12, 2020
@anandwana001
Copy link
Contributor Author

ah, Did check the landscape thing about reveal hint.
Thanks for pointing these, I will update.

@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Aug 14, 2020
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. This implementation is quite nice.

One final bug:

Once you have revealed first hint, then when you have second hint available (not revealed), expand the first hint, and now reveal the second hint and you will notice both hints are expanded.

Hints issue

@rt4914 rt4914 assigned anandwana001 and unassigned rt4914 Aug 14, 2020
@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Aug 15, 2020
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Landscape support for Hints & Solution
2 participants