Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FrameLayout for hints and Solution is missing in mobile portrait [Blocked on Highfi work] #1647

Closed
rt4914 opened this issue Aug 13, 2020 · 2 comments
Closed

FrameLayout for hints and Solution is missing in mobile portrait [Blocked on Highfi work] #1647

rt4914 opened this issue Aug 13, 2020 · 2 comments
Assignees
@rt4914
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Aug 13, 2020

In state_fragment.xml file for portrait mobile screen, below mentioned code is missing

 <FrameLayout
      android:id="@+id/hints_and_solution_fragment_placeholder"
      android:layout_width="match_parent"
      android:layout_height="match_parent">
    </FrameLayout>
@rt4914 rt4914 added this to the Alpha milestone Aug 13, 2020
@rt4914 rt4914 self-assigned this Aug 13, 2020
@rt4914 rt4914 changed the title FrameLayout for hints and Solution is missing in mobile portrait FrameLayout for hints and Solution is missing in mobile portrait [Blocked on Highfi work] Aug 13, 2020
@rt4914 rt4914 added Priority: Essential This work item must be completed for its milestone. Status: Not started labels Aug 13, 2020
@anandwana001
Copy link
Contributor

anandwana001 commented Aug 17, 2020 •
edited
Loading

@rt4914 I had added this is my hints and solution PR - https://github.com/oppia/oppia-android/pull/1615/files

@rt4914
Copy link
Contributor Author

rt4914 commented Aug 17, 2020

Closed via #1615

@rt4914 rt4914 closed this as completed Aug 17, 2020
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
Development

No branches or pull requests
3 participants
@rt4914 @BenHenning @anandwana001