Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landscape support for Hints & Solution #1593

Closed
rt4914 opened this issue Aug 10, 2020 · 1 comment · Fixed by #1615
Closed

Landscape support for Hints & Solution #1593

rt4914 opened this issue Aug 10, 2020 · 1 comment · Fixed by #1615
Assignees
@anandwana001
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Aug 10, 2020

Describe the bug
Hints and Solution screen crashed on configuration changed

To Reproduce
Steps to reproduce the behavior:

  1. Go to Fraactions
  2. Skip initial states to go to first question.
  3. Select option 1, twice.
  4. You should see a Hint icon at the bottom-left
  5. Click on hint
  6. In hint screen, change mobile orientation.
  7. Application crashes with following error:

Screenshot 2020-08-10 at 5 49 38 PM

Expected behavior
The application should not crash on configuration change in Hints&Solution.
@rt4914 rt4914 added Type: Bug Priority: Essential This work item must be completed for its milestone. labels Aug 10, 2020
@rt4914 rt4914 added this to the Alpha milestone Aug 10, 2020
@rt4914 rt4914 mentioned this issue Aug 10, 2020
Closed
@anandwana001
Copy link
Contributor

This requires using state as a Pacelable or Serializable but nothing worked.
Need some other workaround to save this state of state while configuration change.
outState.putSerializable(STATE_SAVED_KEY, state)

@anandwana001 anandwana001 self-assigned this Aug 11, 2020
@anandwana001 anandwana001 mentioned this issue Aug 11, 2020
Merged
8 tasks
rt4914 pushed a commit that referenced this issue Aug 15, 2020
@anandwana001
Fix #1593: Landscape support for Hints & Solution (#1615)
3fb2b1a 
* fix landscape crash

* fix visibility issues

* fix collapse expanded items on click other item

* fix ktlint
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anandwana001 anandwana001

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
Development

Successfully merging a pull request may close this issue.

Fix #1593: Landscape support for Hints & Solution anandwana001/oppia-android
3 participants
@rt4914 @BenHenning @anandwana001