Refactor ProfileId provision process to multiple Activities

[KevinGitonga]

Is your feature request related to a problem? Please describe.

We want to provide ProfileId to all intents across the App in a pattern that will promote long term sustainability of the Oppia App by providing ProfileId in a decoupled manner. This is related to #4762.

Describe the solution you'd like

Pack ProfileId into all Intents so that it can be easily accessed by underlying fragments and child classes.
#5248 introduced a CurrentUserProfileIdIntentDecorator utility to provide methods for adding the ProfileId to an intent, and for extracting it where needed. The PR also refactored a number of screens to use these utility methods.

Describe alternatives you've considered

N/A

Additional context

The pattern requested here was first introduced in CurrentAppScreenNameIntentDecorator.kt to allow the easy access by underlying child classes.

The required decorator, CurrentUserProfileIdIntentDecorator.kt was added in #5248.

The remaining task is to refactor all screens(activities and fragments) so that the profileId is passed/retrieved entirely using this utility throughout the app.

To pass the ProfileId to an intent or bundle, do:

oppia-android/app/src/main/java/org/oppia/android/app/onboarding/CreateProfileFragmentPresenter.kt

Lines 174 to 180 in 8a7fe0a

	val intent =
	IntroActivity.createIntroActivity(activity).apply {
	putProtoExtra(IntroActivity.PARAMS_KEY, params)
	decorateWithUserProfileId(profileId)
	}
	fragment.startActivity(intent)

To retrieve ProfileId from an intent or Bundle, do:

oppia-android/app/src/main/java/org/oppia/android/app/onboarding/IntroActivity.kt

Line 27 in 8a7fe0a

val profileId = intent.extractCurrentUserProfileId()

The best approach for this would be to make changes to a small to medium set of screens at a time, including their related tests to keep the PR sizes reasonably small. For every changed fragment, corresponding changes may be required in the test files.

Multiple contributors can work on this issue at the same time.

[BenHenning]

NB: This is a prerequisite for #4986.

[adhiamboperes]

PR #4869 attempts to solve this issue. The PR has merge conflicts and some broken tests that need to be fixed. @KevinGitonga is unable to complete it at the moment so someone else needs to take over and update the PR.

[adhiamboperes]

@tobioyelekan, could you PTAL at this issue?

[tobioyelekan]

Sure @adhiamboperes , I will take a look and propose a solution

[tobioyelekan]

Hi @adhiamboperes should I start another PR? since #4869 is very old
If so, I think it's best we break the tasks into multiple PRs, maybe scoping it by folder/feature. For example, classroom folder. wdyt?

[adhiamboperes]

@tobioyelekan, maybe you can work on only one package eg classroom for the first PR so that we gain familiarity with the required changes and expected PR size. then for following PRs you can have up to 3 packages.

[tobioyelekan]

Hi @adhiamboperes, I can't find the package for model, and can't import the classes in it, the app still runs though
Please help

[adhiamboperes]

@tobioyelekan, the model package exists. It contains protos. You need to clean and rebuild your project and the imports should then work.

[tobioyelekan]

Thank you @adhiamboperes , I have tried this, even invalidate caches and restart, it's still not working.
I'm currently investigating if it's a problem with my IDE

[adhiamboperes]

@tobioyelekan, could you please move this discussion to the discussions tab? Actually, you can do a search there to see if someone has previously encountered this issue.

[tobioyelekan]

Thanks @adhiamboperes , will check that, for now I've switched back to AS bumble bee, works well there.