Fix part of #4865: Refactor topic to use profileId #5598

tobioyelekan · 2024-12-15T05:05:36Z

Explanation

Fixes part of #4865

This PR aim to refactor topic package to use ProfileId
Changes include all topic fragments, presenters, and TopicActivity
Also updated the test classes.

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

tobioyelekan · 2024-12-15T05:05:57Z

@adhiamboperes PTAL

github-actions · 2024-12-15T06:29:11Z

Coverage Report

Results

Number of files assessed: 39
Overall Coverage: 0.00%
Coverage Analysis: PASS ✅

Exempted coverage

Files exempted from coverage

File	Exemption Reason
CompletedStoryItemViewModel.kt app/src/main/java/org/oppia/android/app/completedstorylist/CompletedStoryItemViewModel.kt	This file is exempted from having a test file; skipping coverage check.
ExplorationActivityPresenter.kt app/src/main/java/org/oppia/android/app/player/exploration/ExplorationActivityPresenter.kt	This file is exempted from having a test file; skipping coverage check.
TopicViewModel.kt app/src/main/java/org/oppia/android/app/topic/TopicViewModel.kt	This file is exempted from having a test file; skipping coverage check.
TopicActivityPresenter.kt app/src/main/java/org/oppia/android/app/topic/TopicActivityPresenter.kt	This file is exempted from having a test file; skipping coverage check.
TopicActivity.kt app/src/main/java/org/oppia/android/app/topic/TopicActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicFragmentPresenter.kt app/src/main/java/org/oppia/android/app/topic/TopicFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
TopicInfoFragment.kt app/src/main/java/org/oppia/android/app/topic/info/TopicInfoFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicInfoFragmentPresenter.kt app/src/main/java/org/oppia/android/app/topic/info/TopicInfoFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
RevisionCardViewModel.kt app/src/main/java/org/oppia/android/app/topic/revisioncard/RevisionCardViewModel.kt	This file is exempted from having a test file; skipping coverage check.
RevisionCardActivity.kt app/src/main/java/org/oppia/android/app/topic/revisioncard/RevisionCardActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
RevisionCardActivityPresenter.kt app/src/main/java/org/oppia/android/app/topic/revisioncard/RevisionCardActivityPresenter.kt	This file is exempted from having a test file; skipping coverage check.
RevisionCardFragment.kt app/src/main/java/org/oppia/android/app/topic/revisioncard/RevisionCardFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicPracticeViewModel.kt app/src/main/java/org/oppia/android/app/topic/practice/TopicPracticeViewModel.kt	This file is exempted from having a test file; skipping coverage check.
TopicPracticeFragment.kt app/src/main/java/org/oppia/android/app/topic/practice/TopicPracticeFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicPracticeFragmentPresenter.kt app/src/main/java/org/oppia/android/app/topic/practice/TopicPracticeFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
TopicFragment.kt app/src/main/java/org/oppia/android/app/topic/TopicFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicRevisionViewModel.kt app/src/main/java/org/oppia/android/app/topic/revision/TopicRevisionViewModel.kt	This file is exempted from having a test file; skipping coverage check.
TopicRevisionFragmentPresenter.kt app/src/main/java/org/oppia/android/app/topic/revision/TopicRevisionFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
TopicRevisionFragment.kt app/src/main/java/org/oppia/android/app/topic/revision/TopicRevisionFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ViewPagerAdapter.kt app/src/main/java/org/oppia/android/app/topic/ViewPagerAdapter.kt	This file is exempted from having a test file; skipping coverage check.
TopicLessonViewModel.kt app/src/main/java/org/oppia/android/app/topic/lessons/TopicLessonViewModel.kt	This file is exempted from having a test file; skipping coverage check.
TopicLessonsFragmentPresenter.kt app/src/main/java/org/oppia/android/app/topic/lessons/TopicLessonsFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
TopicLessonsFragment.kt app/src/main/java/org/oppia/android/app/topic/lessons/TopicLessonsFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
RouteToRevisionCardListener.kt app/src/main/java/org/oppia/android/app/topic/RouteToRevisionCardListener.kt	This file is exempted from having a test file; skipping coverage check.
HomeFragmentPresenter.kt app/src/main/java/org/oppia/android/app/home/HomeFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
RouteToTopicListener.kt app/src/main/java/org/oppia/android/app/home/RouteToTopicListener.kt	This file is exempted from having a test file; skipping coverage check.
HomeActivity.kt app/src/main/java/org/oppia/android/app/home/HomeActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
RouteToTopicPlayStoryListener.kt app/src/main/java/org/oppia/android/app/home/RouteToTopicPlayStoryListener.kt	This file is exempted from having a test file; skipping coverage check.
PromotedStoryViewModel.kt app/src/main/java/org/oppia/android/app/home/promotedlist/PromotedStoryViewModel.kt	This file is incompatible with code coverage tooling; skipping coverage check.
RecentlyPlayedStorySummaryViewModel.kt app/src/main/java/org/oppia/android/app/profileprogress/RecentlyPlayedStorySummaryViewModel.kt	This file is exempted from having a test file; skipping coverage check.
OngoingTopicItemViewModel.kt app/src/main/java/org/oppia/android/app/ongoingtopiclist/OngoingTopicItemViewModel.kt	This file is exempted from having a test file; skipping coverage check.
ClassroomListFragmentPresenter.kt app/src/main/java/org/oppia/android/app/classroom/ClassroomListFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
ClassroomListActivity.kt app/src/main/java/org/oppia/android/app/classroom/ClassroomListActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
NavigationDrawerTestActivity.kt app/src/main/java/org/oppia/android/app/testing/NavigationDrawerTestActivity.kt	This file is exempted from having a test file; skipping coverage check.
TopicTestActivity.kt app/src/main/java/org/oppia/android/app/testing/TopicTestActivity.kt	This file is exempted from having a test file; skipping coverage check.
TopicTestActivityForStory.kt app/src/main/java/org/oppia/android/app/testing/TopicTestActivityForStory.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicRevisionTestActivity.kt app/src/main/java/org/oppia/android/app/testing/TopicRevisionTestActivity.kt	This file is exempted from having a test file; skipping coverage check.
TopicRevisionTestActivityPresenter.kt app/src/main/java/org/oppia/android/app/testing/TopicRevisionTestActivityPresenter.kt	This file is exempted from having a test file; skipping coverage check.
HomeFragmentTestActivity.kt app/src/main/java/org/oppia/android/app/testing/HomeFragmentTestActivity.kt	This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

…o_use_profileId

tobioyelekan · 2024-12-16T23:34:20Z

@adhiamboperes not sure why the Roboelectric tests failed, could you please help run it again?

github-actions · 2024-12-17T04:13:47Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 300 bytes (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 234 bytes (Removed)

Method count: 260195 (old), 260196 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6818 (old), 6818 (new), 0 (No change)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 380 (old), 380 (new), 0 (No change)
Id: 1275 (old), 1275 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 380 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 852 (old), 852 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 300 bytes (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 241 bytes (Removed)
Method count: 260195 (old), 260196 (new), 1 (Added)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 112 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 19 bytes (Added)

Method count: 116265 (old), 116266 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5786 (old), 5786 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 785 (old), 785 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 108 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 38 bytes (Removed)
Method count: 116265 (old), 116266 (new), 1 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 104 bytes (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 1731 bytes (Removed)

Method count: 116271 (old), 116272 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5786 (old), 5786 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 785 (old), 785 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 108 bytes (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 341 bytes (Removed)
Method count: 116271 (old), 116272 (new), 1 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 100 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 229 bytes (Added)

Method count: 116271 (old), 116272 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5786 (old), 5786 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 785 (old), 785 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 96 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 217 bytes (Removed)
Method count: 116271 (old), 116272 (new), 1 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

adhiamboperes · 2024-12-17T09:19:01Z

@adhiamboperes not sure why the Roboelectric tests failed, could you please help run it again?

> Process 'Gradle Test Executor 3' finished with non-zero exit value 134

Is typically a timeout error. I have re-run the tests, it should pass.

…o_use_profileId

tobioyelekan · 2024-12-18T11:47:32Z

@adhiamboperes PTAL

adhiamboperes

Thanks @tobioyelekan! PTAL at my comments.

app/src/main/java/org/oppia/android/app/topic/TopicFragment.kt

app/src/main/java/org/oppia/android/app/topic/TopicFragmentPresenter.kt

app/src/main/java/org/oppia/android/app/topic/TopicViewModel.kt

app/src/main/java/org/oppia/android/app/topic/info/TopicInfoFragment.kt

app/src/main/java/org/oppia/android/app/topic/lessons/TopicLessonsFragment.kt

app/src/main/java/org/oppia/android/app/topic/lessons/TopicLessonViewModel.kt

app/src/main/java/org/oppia/android/app/topic/practice/TopicPracticeFragment.kt

app/src/main/java/org/oppia/android/app/topic/revision/TopicRevisionFragment.kt

app/src/main/java/org/oppia/android/app/topic/revision/TopicRevisionViewModel.kt

oppiabot · 2024-12-18T15:06:31Z

Hi @tobioyelekan, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

…o_use_profileId

tobioyelekan · 2024-12-18T23:53:36Z

Thanks @adhiamboperes , all changes made. PTAL

oppiabot · 2024-12-18T23:56:41Z

Unassigning @tobioyelekan since a re-review was requested. @tobioyelekan, please make sure you have addressed all review comments. Thanks!

github-actions · 2024-12-21T04:26:14Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 412 bytes (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 254 bytes (Added)

Method count: 260196 (old), 260198 (new), 2 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6818 (old), 6818 (new), 0 (No change)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 380 (old), 380 (new), 0 (No change)
Id: 1275 (old), 1275 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 380 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 852 (old), 852 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 412 bytes (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 135 bytes (Added)
Method count: 260196 (old), 260198 (new), 2 (Added)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 56 bytes (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 169 bytes (Added)

Method count: 116267 (old), 116268 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5786 (old), 5786 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 785 (old), 785 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 56 bytes (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 1141 bytes (Added)
Method count: 116267 (old), 116268 (new), 1 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 104 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 2146 bytes (Added)

Method count: 116273 (old), 116274 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5786 (old), 5786 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 785 (old), 785 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 104 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 631 bytes (Added)
Method count: 116273 (old), 116274 (new), 1 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 44 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 1672 bytes (Added)

Method count: 116273 (old), 116274 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5786 (old), 5786 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 785 (old), 785 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 44 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 236 bytes (Added)
Method count: 116273 (old), 116274 (new), 1 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

adhiamboperes

Thanks @tobioyelekan, this LGTM!

Just a note - we prefer allowing the person who created a comment to resolve it, so they can first verify that it has been satisfactorily addressed. On your part, you can respond to the comment with: done, fixed, updated etc.

adhiamboperes · 2024-12-23T13:08:22Z

Rerunning CI since there were unclear failures.

oppiabot · 2024-12-23T13:11:00Z

Hi @tobioyelekan, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

tobioyelekan added 4 commits December 15, 2024 00:46

refactor topic to use profileId

fc67b7d

fix code format

c2a193a

update tests

a4f2d6c

fix code format

492e4a0

tobioyelekan requested a review from a team as a code owner December 15, 2024 05:05

tobioyelekan requested a review from adhiamboperes December 15, 2024 05:05

oppiabot bot assigned adhiamboperes Dec 15, 2024

tobioyelekan added 2 commits December 15, 2024 23:47

Merge remote-tracking branch 'upstream/develop' into refactor_topic_t…

66938fa

…o_use_profileId

fix code format

52037c8

Merge remote-tracking branch 'upstream/develop' into refactor_topic_t…

0f48ca7

…o_use_profileId

tobioyelekan changed the title ~~Refactor topic to use profile~~ Refactor topic to use profileId Dec 18, 2024

adhiamboperes requested changes Dec 18, 2024

View reviewed changes

adhiamboperes changed the title ~~Refactor topic to use profileId~~ Fix part of #4865: Refactor topic to use profileId Dec 18, 2024

adhiamboperes removed their assignment Dec 18, 2024

oppiabot bot assigned tobioyelekan Dec 18, 2024

tobioyelekan added 3 commits December 19, 2024 00:49

use profileId default instance instead

17fd5ea

rename setInternalProfileId to setProfileId

7349c23

Merge remote-tracking branch 'upstream/develop' into refactor_topic_t…

a49b765

…o_use_profileId

tobioyelekan requested a review from adhiamboperes December 18, 2024 23:53

oppiabot bot assigned adhiamboperes and unassigned tobioyelekan Dec 18, 2024

combine two lines into 1

f6a39aa

adhiamboperes approved these changes Dec 23, 2024

View reviewed changes

Merge branch 'develop' into refactor_topic_to_use_profileId

d994616

adhiamboperes assigned tobioyelekan and unassigned adhiamboperes Dec 23, 2024

oppiabot bot added the PR: LGTM label Dec 23, 2024

Merge branch 'develop' into refactor_topic_to_use_profileId

de8ead3

adhiamboperes enabled auto-merge (squash) December 23, 2024 14:37

adhiamboperes merged commit 8f47196 into oppia:develop Dec 23, 2024
44 checks passed

Fix part of #4865: Refactor topic to use profileId #5598

Fix part of #4865: Refactor topic to use profileId #5598

Conversation

tobioyelekan commented Dec 15, 2024

Explanation

Fixes part of #4865

Essential Checklist

tobioyelekan commented Dec 15, 2024

github-actions bot commented Dec 15, 2024

Coverage Report

Results

Exempted coverage

tobioyelekan commented Dec 16, 2024

github-actions bot commented Dec 17, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Beta

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Ga

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

adhiamboperes commented Dec 17, 2024

tobioyelekan commented Dec 18, 2024

adhiamboperes left a comment

Choose a reason for hiding this comment

oppiabot bot commented Dec 18, 2024

tobioyelekan commented Dec 18, 2024

oppiabot bot commented Dec 18, 2024

github-actions bot commented Dec 21, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha