Add proto config files for feature and required class. #4869

KevinGitonga · 2023-02-06T11:43:21Z

Fix #4865
When this PR is merged it should enable developers to easily access ProfileId which will be wrapped wrapped into all Activities Intents.

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

KevinGitonga · 2023-02-07T17:28:24Z

Hi @BenHenning, I have added the core classes and refactored the implementation to to enable provision of ProfileId to multiple activities intents. Kindly check on the implementation and let me know if i am in the right direction on this. Please note that it works as expected with gradle but not via bazel. This is even after adding bazel config for the decorator class similarly to screen name decorator.Thanks.

…of "putEXtra".

BenHenning

Thanks @KevinGitonga. Overall I think the approach looks reasonable, though I had one suggestion to simplify the decorator a bit.

That being said, what precisely isn't working for Bazel? The CI checks are passing, so it seems like everything is working correctly. Am I missing something?

utility/src/main/java/org/oppia/android/util/profile/CurrentUserProfileIdIntentDecorator.kt

…sed by reviewer.

BenHenning

Thanks @KevinGitonga! I think this looks quite solid! I had a bunch of style comments, and a few of substance. PTAL.

app/src/main/java/org/oppia/android/app/administratorcontrols/AdministratorControlsActivity.kt

app/src/main/java/org/oppia/android/app/testing/NavigationDrawerTestActivity.kt

...edTest/java/org/oppia/android/app/administratorcontrols/AdministratorControlsActivityTest.kt

...c/sharedTest/java/org/oppia/android/app/completedstorylist/CompletedStoryListActivityTest.kt

app/src/sharedTest/java/org/oppia/android/app/home/HomeActivityTest.kt

utility/src/main/java/org/oppia/android/util/profile/CurrentUserProfileIdIntentDecorator.kt

utility/src/test/java/org/oppia/android/util/profile/CurrentUserProfileIdIntentDecoratorTest.kt

…to profile_id_provision_feature

oppiabot · 2023-07-17T10:48:33Z

Hi @KevinGitonga, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

oppiabot · 2023-07-26T23:55:15Z

Hi @KevinGitonga, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

oppiabot · 2023-08-03T12:22:55Z

Hi @KevinGitonga, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

oppiabot · 2023-08-14T13:38:33Z

Hi @KevinGitonga, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

# Conflicts: # app/src/main/java/org/oppia/android/app/home/recentlyplayed/RecentlyPlayedFragmentPresenter.kt # app/src/sharedTest/java/org/oppia/android/app/administratorcontrols/learneranalytics/ProfileAndDeviceIdActivityTest.kt # app/src/sharedTest/java/org/oppia/android/app/profileprogress/ProfileProgressFragmentTest.kt

KevinGitonga · 2023-08-23T10:00:23Z

Hi @adhiamboperes updated per the comments, might not fully resolve the static failures as i am using my mac which doesn't support bazel used in project last i checked. PTAL thanks

oppiabot · 2023-08-30T10:25:58Z

Hi @KevinGitonga, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

oppiabot · 2023-09-14T19:58:04Z

Hi @KevinGitonga, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

oppiabot · 2023-09-27T15:17:02Z

Hi @KevinGitonga, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

KevinGitonga added 5 commits February 6, 2023 14:38

Add proto config files for feature and required class.

f255fae

Add Bazel config on profile Build.bazel.

f583167

Fix lint buildifier issue on profile Build.bazel.

19564c4

Add profileId decorator to more Activities and refactor to use the same.

d89f05d

Remove redundant Kdoc exemption.

ecd09ae

KevinGitonga assigned BenHenning Feb 7, 2023

KevinGitonga added 3 commits February 8, 2023 13:00

Add dependency on library to App module to resolve dependency issues.

e13b2c1

Refactor tests to use CurrentUserProfileIdIntentDecorator.kt instead …

1cdbbb0

…of "putEXtra".

Update to use ProfileId from protoExtra.

5866d69

BenHenning reviewed Feb 8, 2023

View reviewed changes

utility/src/main/java/org/oppia/android/util/profile/CurrentUserProfileIdIntentDecorator.kt Outdated Show resolved Hide resolved

BenHenning assigned KevinGitonga and unassigned BenHenning Feb 8, 2023

KevinGitonga added 2 commits February 9, 2023 15:27

Add Activity tests for this enhancement and also make changes as advi…

31c1621

…sed by reviewer.

Merge branch 'develop' into profile_id_provision_feature

3b17968

KevinGitonga marked this pull request as ready for review February 9, 2023 16:41

KevinGitonga requested a review from rt4914 as a code owner February 9, 2023 16:41

KevinGitonga assigned BenHenning and unassigned KevinGitonga Feb 9, 2023

BenHenning requested changes Feb 14, 2023

View reviewed changes

BenHenning assigned KevinGitonga and unassigned BenHenning Feb 14, 2023

KevinGitonga added 8 commits February 14, 2023 18:07

Refactor to remove internalId usages to ProfileId directly.

43141c9

Merge branch 'oppia:develop' into profile_id_provision_feature

2f8de67

Merge remote-tracking branch 'origin/profile_id_provision_feature' in…

9dcf79f

…to profile_id_provision_feature

Remove redundant exemptions and fix some failing tests.

b6f7820

Fix some failing tests.

8076486

Fix some failing tests.

c7c55b0

Use getDefautInstance.

7215556

Fix more failing tests.

e619ecb

oppiabot bot assigned KevinGitonga Jul 10, 2023

oppiabot bot added stale Corresponds to items that haven't seen a recent update and may be automatically closed. and removed stale Corresponds to items that haven't seen a recent update and may be automatically closed. labels Jul 17, 2023

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 26, 2023

adhiamboperes removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 27, 2023

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Aug 3, 2023

adhiamboperes removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Aug 7, 2023

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Aug 14, 2023

adhiamboperes removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Aug 17, 2023

KevinGitonga added 2 commits August 23, 2023 12:35

Minor updates per reviewer's comments.

ef34293

KevinGitonga assigned adhiamboperes and unassigned KevinGitonga Aug 23, 2023

oppiabot bot added stale Corresponds to items that haven't seen a recent update and may be automatically closed. and removed stale Corresponds to items that haven't seen a recent update and may be automatically closed. labels Aug 30, 2023

Merge branch 'develop' into profile_id_provision_feature

c42f1d8

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 14, 2023

adhiamboperes mentioned this pull request Sep 20, 2023

Refactor ProfileId provision process to multiple Activities #4865

Open

adhiamboperes removed their assignment Sep 20, 2023

oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 20, 2023

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 27, 2023

oppiabot bot closed this Oct 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add proto config files for feature and required class. #4869

Add proto config files for feature and required class. #4869

KevinGitonga commented Feb 6, 2023 •

edited by adhiamboperes

Loading

KevinGitonga commented Feb 7, 2023

BenHenning left a comment

BenHenning left a comment

oppiabot bot commented Jul 17, 2023

oppiabot bot commented Jul 26, 2023

oppiabot bot commented Aug 3, 2023

oppiabot bot commented Aug 14, 2023

KevinGitonga commented Aug 23, 2023

oppiabot bot commented Aug 30, 2023

oppiabot bot commented Sep 14, 2023

oppiabot bot commented Sep 27, 2023

Add proto config files for feature and required class. #4869

Add proto config files for feature and required class. #4869

Conversation

KevinGitonga commented Feb 6, 2023 • edited by adhiamboperes Loading

Essential Checklist

For UI-specific PRs only

KevinGitonga commented Feb 7, 2023

BenHenning left a comment

Choose a reason for hiding this comment

BenHenning left a comment

Choose a reason for hiding this comment

oppiabot bot commented Jul 17, 2023

oppiabot bot commented Jul 26, 2023

oppiabot bot commented Aug 3, 2023

oppiabot bot commented Aug 14, 2023

KevinGitonga commented Aug 23, 2023

oppiabot bot commented Aug 30, 2023

oppiabot bot commented Sep 14, 2023

oppiabot bot commented Sep 27, 2023

KevinGitonga commented Feb 6, 2023 •

edited by adhiamboperes

Loading