Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11y] Add label for all non-test activities #3602

Closed
6 tasks done
rt4914 opened this issue Jul 28, 2021 · 37 comments · Fixed by #4103
Closed
6 tasks done

[A11y] Add label for all non-test activities #3602

rt4914 opened this issue Jul 28, 2021 · 37 comments · Fixed by #4103
Labels
good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jul 28, 2021 •
edited by adhiamboperes
Loading

[A11y] Add label for all non-test activities

Reference

Example PR: https://github.com/oppia/oppia-android/pull/3227/files
@rt4914 rt4914 added this to the Beta milestone Jul 28, 2021
@rt4914 rt4914 added Priority: Essential This work item must be completed for its milestone. Status: Not started Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. labels Jul 28, 2021
@rt4914 rt4914 mentioned this issue Jul 28, 2021
Merged
8 tasks
@rt4914
Copy link
Contributor Author

rt4914 commented Sep 1, 2021

@vrajdesai78 Can you work on this issue? If yes, suggest picking one of the mentioned files and creating PR for that first.

@vrajdesai78
Copy link
Contributor

@rt4914 I want to work on this issue. I will create label for HomeActivity

@deepanshu731
Copy link
Contributor

@rt4914 I want to create label for ProfilePictureActivity.

@vrajdesai78 vrajdesai78 mentioned this issue Sep 27, 2021
Merged
6 tasks
@vrajdesai78
Copy link
Contributor

@rt4914 I am receiving static checks failed. Will I need to do anything else than adding label for HomeActivity in android manifest file and creating value in strings.xml

@rt4914
Copy link
Contributor Author

rt4914 commented Sep 28, 2021

@vrajdesai78 I have commented on PR

@rt4914 rt4914 added the good first issue This item is good for new contributors to make their pull request. label Sep 29, 2021
@bkaur-bkj
Copy link
Contributor

@rt4914 sir I will make labels for SplashActivity pls assign that part to me.

@bkaur-bkj bkaur-bkj mentioned this issue Oct 1, 2021
Merged
6 tasks
@bkaur-bkj
Copy link
Contributor

@rt4914 sir PTAL

@deepanshu731 deepanshu731 mentioned this issue Oct 5, 2021
Merged
6 tasks
BenHenning pushed a commit that referenced this issue Oct 14, 2021
@deepanshu731
Fix part of #3602: Added label for ProfilePictureActivity (#3881)
e3d9c89 
* addded label for profile picture

* Delete deploymentTargetDropDown.xml

* Update ProfilePictureActivityTest.kt

* Update strings.xml

* Update ProfilePictureActivityTest.kt

* modified script

* Update strings.xml

* changed rule

* Delete deploymentTargetDropDown.xml

* Update ProfilePictureActivityTest.kt

* reformatting

* changed test

* Update ProfilePictureActivityTest.kt
@priyatanu
Copy link
Contributor

@rt4914 I want to work on this WalkthroughActivity activity

@rt4914
Copy link
Contributor Author

rt4914 commented Nov 3, 2021

@priyatanu Sure. Thanks.

@priyatanu
Copy link
Contributor

@priyatanu Sure. Thanks.

Hi @rt4914 , @BenHenning , kindly review my PR - #3983

rt4914 pushed a commit that referenced this issue Nov 17, 2021
@vrajdesai78
Fix part of #3602 Added label for HomeActivity (#3850)
4647538 
* Label added for HomeActivity

* HomeActivity removed from label exemptions

* Removed translatable=false

* Test created for HomeActivity

* removed summary value

* Update deploymentTargetDropDown.xml

* Update deploymentTargetDropDown.xml

* Updated testcase

* Updated strings.xml

* Delete deploymentTargetDropDown.xml

* ActivityTestRule removed

* multiple home string removed

* .idea/runConfigurations.xml file reverted back

* Removed unused imports

* reformated code

* Fixed unnecessary changes

* String.xml updated

* removed changes from strings.xml

* strings.xml updated removed unncessary changes
@vivaansahai
Copy link

Hi, Can I work on RecentlyPlayedActivity?

@priyatanu priyatanu mentioned this issue Dec 28, 2021
Merged
6 tasks
@ankita240796
Copy link
Contributor

Hi @rt4914, can I pick MyDownloadsActivity? Thanks!

@ankita240796 ankita240796 removed their assignment Jan 5, 2022
BenHenning pushed a commit that referenced this issue Jan 8, 2022
@priyatanu
Fix part of #3602: Add label for Walk Through Activity (#3983)
87a7acc 
* Add lable for Wal Through Activity

* Add Test WalkthroughActivityLabelTest for  adding label to Activity

* Remove WalkthroughActivityLabelTest and add the test case in WalkthroughActivityTest

* Fix failing accessibiltiy failure and clean up acivity scenario

* Add new Line to proto file

* Fix Test Cases for Walk Through label change
@Rishavgupta12345
Copy link

can i work on RecentlyPlayedActivity

@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 7, 2022
@BenHenning BenHenning added Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_learner labels Sep 15, 2022
@BenHenning BenHenning removed this from the Beta milestone Sep 16, 2022
@deonwaju
Copy link
Collaborator

deonwaju commented Dec 8, 2022

I would like to add the label for profileEditActivity

@MohitGupta121
Copy link
Member

@deonwaju assigned go ahead.
If you have any query feel free to ask me.

@deonwaju
Copy link
Collaborator

deonwaju commented Dec 9, 2022

Thank you.

@deonwaju deonwaju mentioned this issue Dec 10, 2022
Closed
6 tasks
@adhiamboperes adhiamboperes mentioned this issue Mar 8, 2023
Merged
6 tasks
@chrislee115
Copy link
Contributor

Hi! Can I work on ProfileEditActivity?

@adhiamboperes
Copy link
Collaborator

adhiamboperes commented Mar 13, 2023 •
edited
Loading

Hi! Can I work on ProfileEditActivity?

Hi @chrislee115, someone is already working on this issue, but you can look at this other one: #3557 or #2116

BenHenning added a commit that referenced this issue Mar 23, 2023
@kkmurerwa @BenHenning
Fix part of #3602: Add accessibility label for ProfileEditActivity (#…
81956ba 
…4894)

<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->
Fix part of #3602: When merged, this PR will;
- Create a strings item in vaues/strings.xml with the accessibility text
label for the ProfileEditActivity.
- Add a label for the activity in the manifest file.
- Remove the activity from the accessibility_label_exemptions.textproto
file.
- Add test to check that the appropriate label is displayed for
ProfileEditActivity.
- Modified tests in ProfileEditActivityTest to reflect new title
behavior and remove any checks for the username as the toolbar title.
- Removed deprecated testProfileEdit_updateName_checkNewNameDisplayed()
test that checked for previous title behaviour.

New changes after 22/03/23 review;
- Rename the string from R.string.profile_edit_activity_label to
R.string.profile_edit_activity_title
- Update the Manifest file to reflect this change.
- Modify the ProfileEditActivityTest class to reflect the change and
test for the toolbar title.
- Linting check fixes.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

---------

Co-authored-by: Ben Henning <[email protected]>
@adhiamboperes
Copy link
Collaborator

@BenHenning I'm closing this issue since the last task has been completed.

Uticodes pushed a commit to Uticodes/oppia-android that referenced this issue Apr 4, 2023
@kkmurerwa @BenHenning @Uticodes
Fix part of oppia#3602: Add accessibility label for ProfileEditActivi…
b939457 
…ty (oppia#4894)

<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->
Fix part of oppia#3602: When merged, this PR will;
- Create a strings item in vaues/strings.xml with the accessibility text
label for the ProfileEditActivity.
- Add a label for the activity in the manifest file.
- Remove the activity from the accessibility_label_exemptions.textproto
file.
- Add test to check that the appropriate label is displayed for
ProfileEditActivity.
- Modified tests in ProfileEditActivityTest to reflect new title
behavior and remove any checks for the username as the toolbar title.
- Removed deprecated testProfileEdit_updateName_checkNewNameDisplayed()
test that checked for previous title behaviour.

New changes after 22/03/23 review;
- Rename the string from R.string.profile_edit_activity_label to
R.string.profile_edit_activity_title
- Update the Manifest file to reflect this change.
- Modify the ProfileEditActivityTest class to reflect the change and
test for the toolbar title.
- Linting check fixes.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

---------

Co-authored-by: Ben Henning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix part of #3602: Added label for MyDownloadsActivity bhaktideshmukh/oppia-android