-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #3602: Added label for ProfilePictureActivity #3881
Fix part of #3602: Added label for ProfilePictureActivity #3881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deepanshu731 PTAL. Also please add screenshot displaying test case is passing on Espresso. (It is mentioned as last point in your PR description.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @deepanshu731. Just had one follow-up comment, PTAL.
app/src/sharedTest/java/org/oppia/android/app/profileprogress/ProfilePictureActivityTest.kt
Outdated
Show resolved
Hide resolved
….com/deepanshu731/oppia-android into add-label-for-profilepictureactivity commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @deepanshu731! The new test looks good, just had one other comment. PTAL.
app/src/sharedTest/java/org/oppia/android/app/profileprogress/ProfilePictureActivityTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @deepanshu731! LGTM.
Merging since all conversations are resolved & all approvals are present. |
Fix part of #3602 Added label for ProfilePictureActivity.
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: