Fix part of #3602: Add accessibility label for ProfileEditActivity #4894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When merged, this commit will; - Create a strings item in R.strings with the accessibility text for the activity. - Add a label for the activity in the manifest file. - Remove the activity from the accessibility_label_exemptions.textproto file.
adhiamboperes
requested changes
Mar 8, 2023
There was a problem hiding this comment.
Thanks @kkmurerwa!
I have a two comments:
- The PR explanation should start with "Fix part of [A11y] Add label for all non-test activities #3602" so you can link this PR to the issue. (Also, you added the explanation above the heading instead of below it)
- Could you edit the testProfileEditActivity_hasCorrectActivityLabel() test for this change?
kkmurerwa
changed the title
BenHenning
requested changes
Mar 11, 2023
There was a problem hiding this comment.
Thanks @kkmurerwa! Just had one comment looking for clarity. Are we actually changing the title in this PR or just the accessibility label? Bit confused about the test changes here.
app/src/sharedTest/java/org/oppia/android/app/settings/profile/ProfileEditActivityTest.kt
Show resolved
Hide resolved
|
Hi @kkmurerwa, when you'd like someone to take the next action on your PR you can mention them by @xxx PTAL and then oppiabot should assign them for you. Also review the wiki here on general code review guidelines. |
|
@BenHenning PTAL |
|
Unassigning @kkmurerwa since a re-review was requested. @kkmurerwa, please make sure you have addressed all review comments. Thanks! |
BenHenning
reviewed
Mar 22, 2023
app/src/sharedTest/java/org/oppia/android/app/settings/profile/ProfileEditActivityTest.kt
Show resolved
Hide resolved
- Rename the string from R.string.profile_edit_activity_label to R.string.profile_edit_activity_title - Update the Manifest file to reflect this change. - Modify the ProfileEditActivityTest class to reflect the change and test for toolbar title.
|
Hey @BenHenning. I renamed the string, modified the manifest and the relevant test. I hope everything is good now. I have updated the PR comment with the changes made under today's date (22/03/23). PTAL and let me know if there are any further changes needed. |
|
@BenHenning PTAL |
|
Unassigning @kkmurerwa since a re-review was requested. @kkmurerwa, please make sure you have addressed all review comments. Thanks! |
BenHenning
requested changes
Mar 23, 2023
There was a problem hiding this comment.
Thanks @kkmurerwa! This LGTM!
One note: please make sure to reply directly to all comments between review passes (to ensure it's explicitly clear that you've addressed the comments).
app/src/sharedTest/java/org/oppia/android/app/settings/profile/ProfileEditActivityTest.kt
Show resolved
Hide resolved
Uticodes
pushed a commit
to Uticodes/oppia-android
that referenced
this pull request
Apr 4, 2023
…ty (oppia#4894) <!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation <!-- - Explain what your PR does. If this PR fixes an existing bug, please include - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the issue - when this PR is merged. --> Fix part of oppia#3602: When merged, this PR will; - Create a strings item in vaues/strings.xml with the accessibility text label for the ProfileEditActivity. - Add a label for the activity in the manifest file. - Remove the activity from the accessibility_label_exemptions.textproto file. - Add test to check that the appropriate label is displayed for ProfileEditActivity. - Modified tests in ProfileEditActivityTest to reflect new title behavior and remove any checks for the username as the toolbar title. - Removed deprecated testProfileEdit_updateName_checkNewNameDisplayed() test that checked for previous title behaviour. New changes after 22/03/23 review; - Rename the string from R.string.profile_edit_activity_label to R.string.profile_edit_activity_title - Update the Manifest file to reflect this change. - Modify the ProfileEditActivityTest class to reflect the change and test for the toolbar title. - Linting check fixes. ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). --------- Co-authored-by: Ben Henning <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fix part of #3602: When merged, this PR will;
New changes after 22/03/23 review;
Essential Checklist