Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thoroughly test ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifier #1897

Closed
Sarthak2601 opened this issue Sep 24, 2020 · 13 comments · Fixed by #2243
Closed

Thoroughly test ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifier #1897

Sarthak2601 opened this issue Sep 24, 2020 · 13 comments · Fixed by #2243
Assignees
@fsharpasharp
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Sarthak2601
Copy link
Contributor

Sarthak2601 commented Sep 24, 2020 •
edited by rt4914
Loading

Since the ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifier was copied from Oppia web, it didn't have corresponding tests added to verify correctness. These should be ported over from Oppia web as well to ensure that each classifier has working functionality.

Useful reference - https://github.com/oppia/oppia-android/tree/develop/domain/src/test/java/org/oppia/android/domain/classify/rules
@Sarthak2601 Sarthak2601 added Type: Improvement Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. good first issue This item is good for new contributors to make their pull request. labels Sep 24, 2020
@Sarthak2601 Sarthak2601 added this to the Backlog milestone Sep 24, 2020
@Sarthak2601 Sarthak2601 mentioned this issue Sep 24, 2020
Closed
29 tasks
@rt4914 rt4914 changed the title Thoroughly test ItemsSelectionInputDoesNotContainAtLeastOneOfRuleClassifier Thoroughly test ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifier Sep 26, 2020
@BenHenning BenHenning added the Hacktoberfest This is a suggested Hacktoberfest issue. label Oct 1, 2020
@JudeUk
Copy link

JudeUk commented Oct 15, 2020

hello @BenHenning I will like to take this up. can you please provide some useful resources as I might need help successfully completing this thank you.

@rt4914 rt4914 assigned JudeUk and unassigned JudeUk Oct 15, 2020
@rt4914
Copy link
Contributor

rt4914 commented Oct 15, 2020

hello @BenHenning I will like to take this up. can you please provide some useful resources as I might need help successfully completing this thank you.

@JudeUk Thanks for showing interest in Oppia. Before we start assigning you issues checkout our wiki first. This will help you in setting up the project and once you sign the CLA and fill the survey form we can assign you issues to work on.

@JudeUk
Copy link

JudeUk commented Oct 15, 2020

hello @rt4914 I have gone through the set up already.

@JudeUk
Copy link

JudeUk commented Oct 15, 2020

hello @BenHenning I will like to take this up. can you please provide some useful resources as I might need help successfully completing this thank you.

@JudeUk Thanks for showing interest in Oppia. Before we start assigning you issues checkout our wiki first. This will help you in setting up the project and once you sign the CLA and fill the survey form we can assign you issues to work on.

I have already

@rt4914
Copy link
Contributor

rt4914 commented Oct 15, 2020

hello @BenHenning I will like to take this up. can you please provide some useful resources as I might need help successfully completing this thank you.

@JudeUk Thanks for showing interest in Oppia. Before we start assigning you issues checkout our wiki first. This will help you in setting up the project and once you sign the CLA and fill the survey form we can assign you issues to work on.

I have already

Great. I have assigned it to you. Thanks.

@BenHenning
Copy link
Member

@JudeUk are you working on this?

@JudeUk
Copy link

JudeUk commented Oct 31, 2020

@JudeUk are you working on this?

yes I will make a draft Pr shortly

@anandwana001
Copy link
Contributor

unassigning @JudeUk as no update.

@BenHenning BenHenning removed the Hacktoberfest This is a suggested Hacktoberfest issue. label Dec 3, 2020
@fsharpasharp
Copy link
Contributor

I can work on this.

@anandwana001
Copy link
Contributor

I can work on this.

Hi, @fsharpasharp just to confirm before start contributing, Did you completed with the Onboarding process?
https://github.com/oppia/oppia-android/wiki#onboarding-instructions

@fsharpasharp
Copy link
Contributor

Yes, I have! :)

@anandwana001
Copy link
Contributor

Yes, I have! :)

It looks like you had signed the CLA, but haven't filled the Contributor Survey yet. Please fill the contributor survey from the onboarding instruction before starting with the contribution.

@fsharpasharp
Copy link
Contributor

I thought I did, but I've filled the survey for sure now. Let me know if it shows up.

This was referenced Dec 9, 2020
Closed
Merged
BenHenning pushed a commit that referenced this issue Dec 17, 2020
@fsharpasharp
Fix #1897: Add tests for ItemSelectionInputDoesNotContainAtLeastOneOf…
6131e0a 
…RuleClassifierProvider (#2243)

* Add tests for ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProvider.

* Add additional tests and rename variables.
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fsharpasharp fsharpasharp

Labels
good first issue This item is good for new contributors to make their pull request. Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
6 participants
@rt4914 @BenHenning @fsharpasharp @anandwana001 @JudeUk @Sarthak2601