Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1897: Add tests for ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProvider #2243

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Fix #1897: Add tests for ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProvider #2243

merged 3 commits into from
Dec 17, 2020

Conversation

fsharpasharp
Copy link
Contributor

@fsharpasharp fsharpasharp commented Dec 9, 2020

Explanation

Fixes #1897. This PR adds the missing test file for ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProvider. I copied the ItemSelectionInputContainsAtLeastOneOfRuleClassifierProvider by changing the assertions since it provides the negation of the same functionality.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@fsharpasharp
Copy link
Contributor Author

@anandwana001, I created a new pull request. Thanks for helping me, I'll be more thorough with the PR guide.

@BenHenning BenHenning self-assigned this Dec 10, 2020
@BenHenning
Copy link
Member

Hi @fsharpasharp. Apologies, but I will need to take a look at this tomorrow.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fsharpasharp
LGTM

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fsharpasharp! The new tests look quite good--I have some suggestions to improve test clarity slightly, and some ideas for additional tests.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall--I think this looks quite good--thanks @fsharpasharp!

@BenHenning BenHenning merged commit 6131e0a into oppia:develop Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thoroughly test ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifier
3 participants