-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1897: Add tests for ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProvider #2243
Fix #1897: Add tests for ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProvider #2243
Conversation
@anandwana001, I created a new pull request. Thanks for helping me, I'll be more thorough with the PR guide. |
Hi @fsharpasharp. Apologies, but I will need to take a look at this tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fsharpasharp
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fsharpasharp! The new tests look quite good--I have some suggestions to improve test clarity slightly, and some ideas for additional tests.
...itemselectioninput/ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
...itemselectioninput/ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
...itemselectioninput/ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProviderTest.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall--I think this looks quite good--thanks @fsharpasharp!
Explanation
Fixes #1897. This PR adds the missing test file for
ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProvider
. I copied theItemSelectionInputContainsAtLeastOneOfRuleClassifierProvider
by changing the assertions since it provides the negation of the same functionality.Checklist