-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1897: Add tests for ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProvider #2238
Fix #1897: Add tests for ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProvider #2238
Conversation
You can setup ktlint to prevent such failures - https://github.com/oppia/oppia-android/wiki/Ktlint-Guide |
Thanks @anandwana001, I'll use that for the future. It seems like the culprit is this line
Not sure if I can break the line. Any ideas? |
It's a max length of char in a line error. Please check the above guide to fix the issue. |
Okay! I added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fsharpasharp
Nit fix suggested
...itemselectioninput/ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProviderTest.kt
Show resolved
Hide resolved
...itemselectioninput/ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProviderTest.kt
Show resolved
Hide resolved
domain/BUILD.bazel
Outdated
@@ -129,6 +129,15 @@ domain_test( | |||
deps = TEST_DEPS, | |||
) | |||
|
|||
domain_test( | |||
name = "TextSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProviderTest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProviderTest
It should be the name of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fsharpasharp The suggestions should be resolved by the author as the reviewer needs to check if the suggested changes are correct or need any further modification.
@fsharpasharp closing this PR as force push is not allowed. |
Explanation
Fixes #1897 by adding tests for
ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProvider
. I copiedItemSelectionInputContainsAtLeastOneOfRuleClassifierProviderTest
and swapped the assertion values. This is possible since the original test file contains the tests for the negation ofItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProvider
.Checklist