Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1897: Add tests for ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProvider #2238

Closed
wants to merge 1 commit into from
Closed

Fix #1897: Add tests for ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProvider #2238

wants to merge 1 commit into from

Conversation

fsharpasharp
Copy link
Contributor

@fsharpasharp fsharpasharp commented Dec 9, 2020

Explanation

Fixes #1897 by adding tests for ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProvider. I copied ItemSelectionInputContainsAtLeastOneOfRuleClassifierProviderTest and swapped the assertion values. This is possible since the original test file contains the tests for the negation of ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProvider.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@anandwana001
Copy link
Contributor

You can setup ktlint to prevent such failures - https://github.com/oppia/oppia-android/wiki/Ktlint-Guide

@fsharpasharp
Copy link
Contributor Author

Thanks @anandwana001, I'll use that for the future. It seems like the culprit is this line

DaggerItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProviderTest_TestApplicationComponent.

Not sure if I can break the line. Any ideas?

@anandwana001
Copy link
Contributor

It's a max length of char in a line error. Please check the above guide to fix the issue.

@fsharpasharp
Copy link
Contributor Author

Okay! I added the // ktlint-disable max-line-length comment to the line.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fsharpasharp
Nit fix suggested

@@ -129,6 +129,15 @@ domain_test(
deps = TEST_DEPS,
)

domain_test(
name = "TextSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProviderTest",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifierProviderTest It should be the name of the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fsharpasharp The suggestions should be resolved by the author as the reviewer needs to check if the suggested changes are correct or need any further modification.

@anandwana001
Copy link
Contributor

@fsharpasharp closing this PR as force push is not allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thoroughly test ItemSelectionInputDoesNotContainAtLeastOneOfRuleClassifier
2 participants