Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app module tests in home and administrator controls for Robolectric #1874

Closed
6 of 8 tasks
Sarthak2601 opened this issue Sep 23, 2020 · 1 comment
Closed
6 of 8 tasks
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Sarthak2601
Copy link
Contributor

Sarthak2601 commented Sep 23, 2020

Currently, the app module test cases in home and administrator controls folders are passing on Espresso but they should also pass on Robolectric. Fix these below mentioned files to make sure that the tests pass on Robolectric.

You can run robolectric tests by following these steps: https://github.com/oppia/oppia-android/wiki/Oppia-Android-Testing#running-roboelectric-tests

Fixing test cases will need to introduce TextApplicationComponent. This can be seen here.

@Sarthak2601 Sarthak2601 added Priority: Essential This work item must be completed for its milestone. SLoP 2020 labels Sep 23, 2020
@Sarthak2601 Sarthak2601 added this to the Beta milestone Sep 23, 2020
rt4914 pushed a commit that referenced this issue Nov 6, 2020
…ric (#2084)

* Fix AdministratorControlsActivityTest for robolectric

* nit change
rt4914 pushed a commit that referenced this issue Nov 23, 2020
* fix span test in home

* nit changes and added more tests
rt4914 pushed a commit that referenced this issue Nov 23, 2020
* fix span test of RecentlyPlayedFragmentTest

* nit update
@anandwana001
Copy link
Contributor

Closing this issue as it is completed in sub-prs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

No branches or pull requests

3 participants