Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #1874: Fix few RecentlyPlayedFragment tests for Robolectric #2071

Conversation

anandwana001
Copy link
Contributor

@anandwana001 anandwana001 commented Nov 2, 2020

Explanation

Fix part of #1874
Fixing RecentlyPlayedFragmentTest for robolectric Test

Reviewer

Modified 2 test for Tablet in Espresso
Fix all the required test for Robolectric
Skipping 2 tests, as both required a bit deep investigation with Delay in Robolectric.

  • testRecentlyPlayedTestActivity_configurationChange_checkSpanForItem2_spanSizeIsThreeOrFour
  • testRecentlyPlayedTestActivity_configurationChange_checkSpanForItem0_spanSizeIsThreeOrFour

Both these tests are failing on Robolectric but Passing on Espresso.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR itself we should update the test names to make sure that the character limit is fulfilled for ktlint check.

Thanks @anandwana001

@rt4914 rt4914 assigned anandwana001 and unassigned rt4914 Nov 3, 2020
@anandwana001
Copy link
Contributor Author

In this PR itself we should update the test names to make sure that the character limit is fulfilled for ktlint check.

Thanks @anandwana001

But there's a ongoing pr from a new contributor and it's in review process already. Might lead to lot of conflicts.

@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Nov 4, 2020
@rt4914
Copy link
Contributor

rt4914 commented Nov 4, 2020

In this PR itself we should update the test names to make sure that the character limit is fulfilled for ktlint check.
Thanks @anandwana001

But there's a ongoing pr from a new contributor and it's in review process already. Might lead to lot of conflicts.

Makes sense. Approving and merging now.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit 29966c0 into oppia:develop Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants