Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #1874: Fix span test for Home #2154

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Fix part of #1874: Fix span test for Home #2154

merged 2 commits into from
Nov 23, 2020

Conversation

anandwana001
Copy link
Contributor

@anandwana001 anandwana001 commented Nov 23, 2020 •
edited
Loading

Explanation

Fix part of #1874
Span test is Home moved to new HomeSpanTest

Screenshot 2020-11-23 at 11 35 11

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@anandwana001 anandwana001 requested a review from rt4914 November 23, 2020 04:24
rt4914
rt4914 suggested changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes. Thanks.

app/src/test/java/org/oppia/android/app/testing/HomeSpanTest.kt Outdated Show resolved Hide resolved
app/src/test/java/org/oppia/android/app/testing/HomeSpanTest.kt Show resolved Hide resolved
@rt4914 rt4914 assigned anandwana001 and unassigned rt4914 Nov 23, 2020
@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Nov 23, 2020
@rt4914
Copy link
Contributor

rt4914 commented Nov 23, 2020

I am getting this error of No tests were found. @anandwana001
Screenshot 2020-11-23 at 12 01 03 PM

@anandwana001 anandwana001 mentioned this pull request Nov 23, 2020
Closed
8 tasks
rt4914
rt4914 approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit f3f2358 into oppia:develop Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anandwana001 @rt4914