Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Structure: AudioFragment #162

Closed
BenHenning opened this issue Sep 20, 2019 · 1 comment · Fixed by #208
Closed

UI Structure: AudioFragment #162

BenHenning opened this issue Sep 20, 2019 · 1 comment · Fixed by #208
Assignees
@jamesxu0
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.2 Release Block...

Comments

@BenHenning
Copy link
Member

This is tracking implementing the UI structure for the audio bar fragment.
@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Sep 20, 2019
@BenHenning
Copy link
Member Author

This is blocked on #123.

This was referenced Sep 20, 2019
Closed
Closed
@BenHenning BenHenning changed the title UI Structure: AudioFragment [Blocked: #123] UI Structure: AudioFragment Sep 30, 2019
@BenHenning BenHenning mentioned this issue Sep 30, 2019
Closed
@jamesxu0 jamesxu0 mentioned this issue Oct 6, 2019
Merged
6 tasks
jamesxu0 added a commit that referenced this issue Oct 15, 2019
@jamesxu0
Fixes #162: Connects AudioPlayerController to AudioFragment (#208)
feec104 
* Using data binding for audio controller

* Started getting data from exploration

* separated live data and get exploration

* Working on configuration change

* made separate listener for persistence

* fixed ondestroy and onpause cases, checks for configuration change

* parsing json for recorded voiceovers

* Added comments and added languages to saved state

* Started test cases

* added additional controller test

* Fixed easy comments

* Added GCS resource bucket name module

* Started testing setup

* initial testing stubs

* Can't fix drawable matcher

* Added more UI tests

* Mostly nit fixes
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesxu0 jamesxu0

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.2 Release Blockers (Prototype MR2)
Development

Successfully merging a pull request may close this issue.

Fixes #162: Connects AudioPlayerController to AudioFragment oppia/oppia-android
2 participants
@BenHenning @jamesxu0