Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Structure: AudioFragment #130

Closed
BenHenning opened this issue Sep 18, 2019 · 2 comments
Closed

UI Structure: AudioFragment #130

BenHenning opened this issue Sep 18, 2019 · 2 comments
Assignees
@jamesxu0
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.2 Release Block...

Comments

@BenHenning
Copy link
Member

This is tracking implementing the low-fidelity structures for #17.
@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Sep 18, 2019
@BenHenning BenHenning added this to the Prototype -- UI milestone Sep 18, 2019
@BenHenning
Copy link
Member Author

/cc @jamesxu0

@BenHenning BenHenning mentioned this issue Sep 18, 2019
Closed
6 tasks
@BenHenning BenHenning changed the title Introduce low fidelity UI structure for the audio bar UI Structure: AudioFragment Sep 20, 2019
@BenHenning BenHenning assigned jamesxu0 and unassigned rt4914 Sep 23, 2019
rt4914 added a commit that referenced this issue Sep 25, 2019
@rt4914
Fix part of #130: Cellular data alert in audio player (#146)
4404f71 
* Celluar data alert in audio player

* Javadoc updates

* Changed CellularDataInterface with simpler methods

* CellularDataFragment shifted to StateFragment

* Imrpovised Language and Celluar Fragments

* Implementation change in CellularDataINterface

* Implementation change in LanguageInterface

* Complete cellular, audio, language screen flow test

* Nit changes

* Nit changes and removed try-catch-throw code

* Removed unnecessary interface code

* Remove StateFragment usgae from HomeActivityController

* Nit javadoc changes

* Optimise DialogFragment code and test case

* Code optimization

* Updated isAudioFragmemntVisible usage

* Data share via Bundle in DialogFragment

* Using targetFragment for interfaces

* Using childFragmentManager

* Test case for CellularDataDialogFragment
@BenHenning BenHenning mentioned this issue Sep 27, 2019
Merged
6 tasks
@BenHenning
Copy link
Member Author

This is apparently a duplicate of #162. Closing this in favor of that issue.

jamesxu0 added a commit that referenced this issue Oct 6, 2019
@jamesxu0
Fixes part of #123, #116, and #130: Cellular Data Controller (#194)
cf4b52c 
* Created CellularDialogController

* Started making tests for controller

* Removed import

* Fixed test cases and renamed to hideDialog

* Fixed comments

* Added use cellular data value and added test cases

* Started adding test cases

* Setup initial testing environment for state fragment

* Add more test cases

* Changed cellular data controller methods to always and never use cellular data
@BenHenning BenHenning closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2022
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesxu0 jamesxu0

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.2 Release Blockers (Prototype MR2)
Development

No branches or pull requests
3 participants
@rt4914 @BenHenning @jamesxu0