Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce interface for AudioPlayerController #123

Closed
BenHenning opened this issue Sep 17, 2019 · 0 comments · Fixed by #149
Closed

Introduce interface for AudioPlayerController #123

BenHenning opened this issue Sep 17, 2019 · 0 comments · Fixed by #149
Assignees
@jamesxu0
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.1 Release Block...

Comments

@BenHenning
Copy link
Member

This is tracking introducing a stubbed interface for #116 without the real implementation being complete.
@BenHenning BenHenning mentioned this issue Sep 17, 2019
Closed
@BenHenning BenHenning added this to the Prototype -- Infra milestone Sep 17, 2019
@BenHenning BenHenning added Where: Infrastructure Priority: Essential This work item must be completed for its milestone. and removed Status: Not started labels Sep 17, 2019
@BenHenning BenHenning mentioned this issue Sep 18, 2019
Closed
6 tasks
@jamesxu0 jamesxu0 mentioned this issue Sep 18, 2019
Closed
6 tasks
This was referenced Sep 20, 2019
Closed
Closed
@jamesxu0 jamesxu0 mentioned this issue Sep 27, 2019
Merged
6 tasks
@BenHenning BenHenning mentioned this issue Sep 27, 2019
Merged
6 tasks
jamesxu0 added a commit that referenced this issue Sep 27, 2019
@jamesxu0
Fix #123 & #116: Functional AudioPlayerController (#149)
3c1d32e 
* copied files over from branch audio-player

* using coroutines to schedule seek bar updates

* Updated to add correct locking and more checks

* Updated comments

* Added change data source function and change to AsyncResult

* Added test cases for controller and observer

* init now return LiveData, release removes observers

* add more locking

* Added more tests

* Finished test cases

* Updated comments

* Updated test names

* Fixed scheduling and error test cases

* Added getPlayProgressLiveData and minor fixes to test cases
jamesxu0 added a commit that referenced this issue Oct 6, 2019
@jamesxu0
Fixes part of #123, #116, and #130: Cellular Data Controller (#194)
cf4b52c 
* Created CellularDialogController

* Started making tests for controller

* Removed import

* Fixed test cases and renamed to hideDialog

* Fixed comments

* Added use cellular data value and added test cases

* Started adding test cases

* Setup initial testing environment for state fragment

* Add more test cases

* Changed cellular data controller methods to always and never use cellular data
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesxu0 jamesxu0

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
0.1 Release Blockers (Prototype MR1)
Development

Successfully merging a pull request may close this issue.

Fix #123 & #116: Functional AudioPlayerController oppia/oppia-android
2 participants
@BenHenning @jamesxu0