Molecule override cmd #1131
Merged
Molecule override cmd #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
/cherrypick v0.4.x |
fabianvf
added a commit
to fabianvf/operator-sdk
that referenced
this pull request
Mar 1, 2019
* use new override_command option * Update tests (cherry picked from commit 9afbe83)
shawn-hurley
pushed a commit
to shawn-hurley/operator-sdk
that referenced
this pull request
Mar 1, 2019
* use new override_command option * Update tests
shawn-hurley
pushed a commit
that referenced
this pull request
Mar 1, 2019
AlexNPavel
pushed a commit
to AlexNPavel/operator-sdk
that referenced
this pull request
Mar 26, 2019
* use new override_command option * Update tests
shawn-hurley
pushed a commit
to shawn-hurley/operator-sdk
that referenced
this pull request
Apr 23, 2019
) * use new override_command option * Update tests (cherry picked from commit 9afbe83)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Molecule now requires you to set the
override_commandoption tofalsein order to prevent it from overriding theCMDdirective on a docker image you're using. This PR brings the generated molecule.yml files up to date. See ansible/molecule#1771Motivation for the change:
We're going to break without it.