Add override_command command to platforms definition
#1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianvf
approved these changes
Feb 22, 2019
|
This looks good to me! Thanks! |
|
Thank you both! I'll fixup the docs and re-run the CI and merge if no one else has further comment 👍 |
Closes ansible#1763. This adds a `override_command` key to the platforms definition. It defaults to true. A user who wants to override the `CMD` directive from their `Dockerfile.j2` can specify `override_command: False` to have it honoured. This allows 3 use cases to be covered: * Getting the zero configuration default of `bash -c ...` * Overriding the `CMD` directive from the `command` key * Overriding the `CMD` directive from the `Dockerfile.j2` and setting `override_command: false` See also: * ansible#1615 * ansible#1614 * ansible#1441 Signed-off-by: Luke Murphy <[email protected]>
decentral1se
force-pushed
the
save-our-cmd
branch
from
1ad1032 to
d525591
Compare
ssbarnea
pushed a commit
to ssbarnea/molecule
that referenced
this pull request
Feb 27, 2019
Closes ansible#1763. This adds a `override_command` key to the platforms definition. It defaults to true. A user who wants to override the `CMD` directive from their `Dockerfile.j2` can specify `override_command: False` to have it honoured. This allows 3 use cases to be covered: * Getting the zero configuration default of `bash -c ...` * Overriding the `CMD` directive from the `command` key * Overriding the `CMD` directive from the `Dockerfile.j2` and setting `override_command: false` See also: * ansible#1615 * ansible#1614 * ansible#1441 Signed-off-by: Luke Murphy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Closes #1763.
This adds a
override_commandkey to the platforms definition. Itdefaults to true. A user who wants to override the
CMDdirective fromtheir
Dockerfile.j2can specifyoverride_command: Falseto have ithonoured.
This allows 3 use cases to be covered:
bash -c ...CMDdirective from thecommandkeyCMDdirective from theDockerfile.j2and settingoverride_command: falseSee also:
while true; do sleep 10000; done#1614I've done some manual testing against this as well for the above use cases.
I'd really appreciate review/testing from @fabianvf and @beenje!