Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulling dependencies from master #1134

Closed
theishshah opened this issue Feb 25, 2019 · 6 comments
Closed

pulling dependencies from master #1134

theishshah opened this issue Feb 25, 2019 · 6 comments
Labels
area/testing Issue related to testing the operator-sdk and subcomponents lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@theishshah
Copy link
Member

Bug Report

What did you do?
A clear and concise description of the steps you took (or insert a code snippet).

TravisCI runs are fetching master versions of Ansible Molecule (and possibly other dependencies) and as a result a breaking change on a dependency can break the sdk. Note that this specific instance of the issue has been fixed in #1131

What did you expect to see?
A clear and concise description of what you expected to happen (or insert a code snippet).

Travis passing when no breaking changes are made in the sdk.

What did you see instead? Under which circumstances?
A clear and concise description of what you expected to happen (or insert a code snippet).

Travis failed on master with no changes in our repo.

Environment

  • operator-sdk version: 0.5.0

Possible Solution

I suggest freezing our dependencies on the latest releases and then updating those versions whenever we lock the new version of the sdk.

@theishshah theishshah changed the title pulling dependancies from master pulling dependencies from master Feb 25, 2019
@theishshah theishshah added area/testing Issue related to testing the operator-sdk and subcomponents versioning labels Feb 25, 2019
@estroz
Copy link
Member

estroz commented Feb 27, 2019

@shawn-hurley @fabianvf thoughts?

@shawn-hurley
Copy link
Member

yep, I totally agree we should, and will, but we actually need a change in molecule that is unreleased (which is going to be released soon). This means that for now, we need to do it this way, we are tracking this and will be making the necessary changes once molecule is released.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 3, 2019
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 3, 2019
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issue related to testing the operator-sdk and subcomponents lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants