Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Dockerfile for building a master image of zipkin-server. #2790

Merged
merged 2 commits into from
Aug 31, 2019

Conversation

anuraaga
Copy link
Contributor

This will be referenced from docker hub to begin automated building of a master docker image of zipkin-server. This solves openzipkin-attic/docker-zipkin#170 which also contains a good summary of the rationale - it's great for previewing development features and testing new infra to be able to just start up a docker image with the latest code, no mvn or jitpack required.

This copies configuration from https://github.com/openzipkin/docker-zipkin - these don't change much so I think copying temporarily should be fine. The intent is to first have master images for all the components that use the latest code, then later gradually migrate release builds off of quay to use these Dockerfiles.

@codefromthecrypt
Copy link
Member

codefromthecrypt commented Aug 30, 2019 via email

@devinsba
Copy link
Member

I'm OK with this, if I had time I wonder if there is a way to make this happen from the other repo

@anuraaga
Copy link
Contributor Author

I think there's always a way with writing code :) But having the Dockerfile in the same repo is least indirect I think - you can always build a docker image as long as you have the code - currently we often push a branch, rewrite the Dockerfile to jitpack, and build from there just to have an image of development code.

We might run into different issues that the separate repo helps with, so we're currently going to copy configuration rather than moving things right away. If we directly compare both worlds, things will probably come into clarity.

@anuraaga anuraaga merged commit 4b84b72 into openzipkin:master Aug 31, 2019
abesto pushed a commit to abesto/zipkin that referenced this pull request Sep 10, 2019
…ipkin#2790)

* Add a Dockerfile for building a master image of zipkin-server.

* README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants