Skip to content
This repository has been archived by the owner on Oct 23, 2019. It is now read-only.

Upload a quay image on every master checkout #170

Closed
jcchavezs opened this issue Jan 4, 2018 · 8 comments
Closed

Upload a quay image on every master checkout #170

jcchavezs opened this issue Jan 4, 2018 · 8 comments
Assignees

Comments

@jcchavezs
Copy link

As of now, docker images are being created on every zipkin release but sometimes, there is a need to use new changes without expecting a release. Currently it is possible by using java -jar but that is in java ecosystems, having the possibility to use docker would unblock non-java infrastructures to use the latest version in a docker container.

My proposal is that we add a hook on openzipkin/zipkin so on every merge into master we trigger a build on this repository and upload the image as zipkin:master. The reason for using master and not latest is to not to mess up with people using already latest as source of truth for getting the last release.

Opinions? @openzipkin/core @adriancole @abesto

@codefromthecrypt
Copy link

cc @openzipkin/devops-tooling

@abesto
Copy link
Contributor

abesto commented Jan 4, 2018

I don't see a down-side, especially with the consideration of not breaking latest in there. If there's a use-case here, I'd say go for it.

(What was the situation that triggered this? I have a weak feeling we may have an X-Y Problem here)

@jcchavezs
Copy link
Author

So recently, some brilliant changes were introduced in the zipkin UI. Since they are in master and not in a release there is no way for people in non java ecosystems to use master. In my case, we use Zipkin in a docker container so it would be great if we could get fresh new changes from master in our docker setup same as java ecosystems would do (fair enough). I can do the changes my self but wanted to get some discussions around it to validate my idea.

@codefromthecrypt
Copy link

codefromthecrypt commented Jan 7, 2018 via email

@jcchavezs jcchavezs self-assigned this Jan 31, 2018
@jcchavezs
Copy link
Author

@anuraaga
Copy link
Contributor

We're now building an image on docker hub for every master push with the master tag so think this is solved.

@anuraaga anuraaga reopened this Aug 29, 2019
@anuraaga
Copy link
Contributor

Nevermind :) I think we'd need to tweak the Dockerfile to be able to build with the master source code. Now that we have the build infra can look into that.

@anuraaga
Copy link
Contributor

We're now building every master commit to openzipkin/zipkin to the openzipkin/zipkin:master docker image tag, so now this should be ready.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants