Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Dockerfile for master build of zipkin-ui. #2793

Merged
merged 2 commits into from
Sep 2, 2019
Merged

Add a Dockerfile for master build of zipkin-ui. #2793

merged 2 commits into from
Sep 2, 2019

Conversation

anuraaga
Copy link
Contributor

@anuraaga anuraaga commented Sep 1, 2019

Equivalent of #2790 for zipkin-ui

codefromthecrypt
codefromthecrypt reviewed Sep 2, 2019
View reviewed changes
Copy link
Member

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I love this.

Eventhough the image is called zipkin-ui I suspect it should be in zipkin-lens/docker directory or docker/lens to make it obvious.

zipkin-ui was just an old name

@anuraaga
Copy link
Contributor Author

anuraaga commented Sep 2, 2019

Cool renamed to lens

codefromthecrypt
codefromthecrypt approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@anuraaga anuraaga merged commit d298b11 into openzipkin:master Sep 2, 2019
abesto pushed a commit to abesto/zipkin that referenced this pull request Sep 10, 2019
@anuraaga @abesto
Add a Dockerfile for master build of zipkin-ui. (openzipkin#2793)
c3fe48d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

@abesto abesto Awaiting requested review from abesto

@devinsba devinsba Awaiting requested review from devinsba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anuraaga @codefromthecrypt