[Proposal] add proposal of daemonset update model #921

xavier-hou · 2022-07-19T01:54:49Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind design

What this PR does / why we need it:

Optimize workload update model in cloud-edge collaboration scenarios

Which issue(s) this PR fixes:

#914

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?

other Note

openyurt-bot · 2022-07-19T01:54:53Z

@HXCGIT: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Signed-off-by: hxcGit [email protected]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind design

What this PR does / why we need it:

Optimize workload update model in cloud-edge collaboration scenarios

Which issue(s) this PR fixes:

#914

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?
other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2022-07-19T02:04:23Z

Codecov Report

Merging #921 (4119405) into master (2d5938d) will increase coverage by 4.92%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #921      +/-   ##
==========================================
+ Coverage   35.37%   40.30%   +4.92%     
==========================================
  Files          76       80       +4     
  Lines        9913    11003    +1090     
==========================================
+ Hits         3507     4435     +928     
- Misses       6141     6241     +100     
- Partials      265      327      +62

Flag	Coverage Δ
unittests	`40.30% <ø> (+4.92%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/controller/kubernetes/util/node/node.go	`82.35% <0.00%> (ø)`
...troller/nodelifecycle/node_lifecycle_controller.go	`56.15% <0.00%> (ø)`
pkg/controller/kubernetes/util/taints/taints.go	`82.08% <0.00%> (ø)`
pkg/controller/nodelifecycle/metrics.go	`100.00% <0.00%> (ø)`
...ontroller/nodelifecycle/scheduler/timed_workers.go	`100.00% <0.00%> (+10.29%)`	⬆️
...ontroller/nodelifecycle/scheduler/taint_manager.go	`84.52% <0.00%> (+84.52%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

rambohe-ch · 2022-07-20T02:40:56Z

@HXCGIT Very appreciate you for posting proposal to upgrade edge workload. and i will take a look soon.

rambohe-ch · 2022-07-21T03:31:24Z

/assign @zyjhtangtang

rambohe-ch · 2022-07-25T09:37:55Z

@HXCGIT codecov error has been fixed, so please rebase the master branch and push --force this pull reqeust.

Signed-off-by: hxcGit <[email protected]>

docs/proposals/20220718-workload-update-model.md

rambohe-ch · 2022-07-26T08:27:35Z

@HXCGIT yes, we need to call RESTFUL api on edge nodes to upgrade edge pods. maybe we can define the RESTFUL api as following:

get all pods on edge node
GET /pods HTTP/1.1
upgrade specified pod on edge node

POST /openyurt.io/v1/{ns}/{podname} HTTP/1.1
BODY: {
    operation: upgrade,
}

kadisi · 2022-07-26T12:04:40Z

@HXCGIT yes, we need to call RESTFUL api on edge nodes to upgrade edge pods. maybe we can define the RESTFUL api as following:

get all pods on edge node
GET /pods HTTP/1.1

upgrade specified pod on edge node
POST /openyurt.io/v1/{ns}/{podname} HTTP/1.1
BODY: {
    operation: upgrade,
}

The API for upgrading, suspending, and resuming the POD can be designed in accordance with the API for POD logs and EXEC

/api/v1/namespaces/{ns}/pods/{podname}/exec
/api/v1/namespaces/{ns}/pods/{podname}/logs

So I suggest the following format：

get all pods on edge node

GET /pods HTTP/1.1

upgrade specified pod on edge node

POST /openyurt.io/v1/namespaces/{ns}/pods/{podname}/upgrade  HTTP/1.1

suspend specified pod on edge node

POST /openyurt.io/v1/namespaces/{ns}/pods/{podname}/suspend  HTTP/1.1

resume specified pod on edge node

POST /openyurt.io/v1/namespaces/{ns}/pods/{podname}/resume  HTTP/1.1

rambohe-ch · 2022-07-27T02:34:19Z

@HXCGIT yes, we need to call RESTFUL api on edge nodes to upgrade edge pods. maybe we can define the RESTFUL api as following:

get all pods on edge node
GET /pods HTTP/1.1

upgrade specified pod on edge node
POST /openyurt.io/v1/{ns}/{podname} HTTP/1.1
BODY: {
    operation: upgrade,
}
The API for upgrading, suspending, and resuming the POD can be designed in accordance with the API for POD logs and EXEC
/api/v1/namespaces/{ns}/pods/{podname}/exec
/api/v1/namespaces/{ns}/pods/{podname}/logs
So I suggest the following format：

get all pods on edge node
GET /pods HTTP/1.1
upgrade specified pod on edge node
POST /openyurt.io/v1/namespaces/{ns}/pods/{podname}/upgrade  HTTP/1.1
suspend specified pod on edge node
POST /openyurt.io/v1/namespaces/{ns}/pods/{podname}/suspend  HTTP/1.1
resume specified pod on edge node
POST /openyurt.io/v1/namespaces/{ns}/pods/{podname}/resume  HTTP/1.1

@kadisi Thanks for your suggestion. agree+1

rambohe-ch · 2022-07-28T06:42:33Z

@HXCGIT beside OnDelete update strategy, we need to add a new annotation(apps.openyurt.io/ota: true) for DaemonSet to specify OTA update strategy.

xavier-hou · 2022-07-29T07:17:20Z

@HXCGIT yes, we need to call RESTFUL api on edge nodes to upgrade edge pods. maybe we can define the RESTFUL api as following:

get all pods on edge node
GET /pods HTTP/1.1

upgrade specified pod on edge node
POST /openyurt.io/v1/{ns}/{podname} HTTP/1.1
BODY: {
    operation: upgrade,
}
The API for upgrading, suspending, and resuming the POD can be designed in accordance with the API for POD logs and EXEC
/api/v1/namespaces/{ns}/pods/{podname}/exec
/api/v1/namespaces/{ns}/pods/{podname}/logs
So I suggest the following format：

get all pods on edge node
GET /pods HTTP/1.1
upgrade specified pod on edge node
POST /openyurt.io/v1/namespaces/{ns}/pods/{podname}/upgrade  HTTP/1.1
suspend specified pod on edge node
POST /openyurt.io/v1/namespaces/{ns}/pods/{podname}/suspend  HTTP/1.1
resume specified pod on edge node
POST /openyurt.io/v1/namespaces/{ns}/pods/{podname}/resume  HTTP/1.1

Many thanks to your suggestion! I will use this form of APIs.

xavier-hou · 2022-07-29T07:17:48Z

@HXCGIT beside OnDelete update strategy, we need to add a new annotation(apps.openyurt.io/ota: true) for DaemonSet to specify OTA update strategy.

OK, a nice suggestion!

rambohe-ch · 2022-08-01T07:37:31Z

@HXCGIT I have a question, how to select one of the ways(OTA-update and NewController) for daemonset by end users?

Signed-off-by: hxcGit <[email protected]>

xavier-hou · 2022-08-01T12:25:08Z

@rambohe-ch I think we can use annotations apps.openyurt.io/upgrade-strategy: ota(for OTA-update), apps.openyurt.io/upgrade-strategy: immediate(for NewController) to distinguish them.

Signed-off-by: hxcGit <[email protected]>

kadisi · 2022-08-02T01:18:02Z

@rambohe-ch I think we can use annotations apps.openyurt.io/upgrade-strategy: ota(for OTA-update), apps.openyurt.io/upgrade-strategy: immediate(for NewController) to distinguish them.

why use apps.openyurt.io/upgrade-strategy: immediate ?

docs/proposals/20220718-workload-update-model.md

kadisi

just some nits

rambohe-ch · 2022-08-02T03:20:46Z

@rambohe-ch I think we can use annotations apps.openyurt.io/upgrade-strategy: ota(for OTA-update), apps.openyurt.io/upgrade-strategy: immediate(for NewController) to distinguish them.

why use apps.openyurt.io/upgrade-strategy: immediate ?

@HXCGIT @kadisi maybe apps.openyurt.io/upgrade-strategy: auto is more reasonable.

kadisi · 2022-08-02T03:36:08Z

@rambohe-ch I think we can use annotations apps.openyurt.io/upgrade-strategy: ota(for OTA-update), apps.openyurt.io/upgrade-strategy: immediate(for NewController) to distinguish them.

why use apps.openyurt.io/upgrade-strategy: immediate ?

@HXCGIT @kadisi maybe apps.openyurt.io/upgrade-strategy: auto is more reasonable.

agree : apps.openyurt.io/upgrade-strategy: auto

rambohe-ch · 2022-08-02T03:37:25Z

/lgtm
/approve

kadisi · 2022-08-02T03:37:30Z

/lgtm

openyurt-bot · 2022-08-02T03:37:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hxcGit, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rambohe-ch]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* add proposal of daemosnet update model Signed-off-by: hxcGit <[email protected]> * modify restAPI format Signed-off-by: hxcGit <[email protected]> * update annotation for auto upgrade model Signed-off-by: hxcGit <[email protected]>

openyurt-bot assigned rambohe-ch Jul 19, 2022

openyurt-bot added the kind/design kind/design label Jul 19, 2022

openyurt-bot requested review from charleszheng44 and rambohe-ch July 19, 2022 01:54

openyurt-bot added the size/L size/L: 100-499 label Jul 19, 2022

xavier-hou force-pushed the proposal-workload-update-model branch from 9590ad6 to 2d9b71d Compare July 19, 2022 01:57

xavier-hou force-pushed the proposal-workload-update-model branch from 2d9b71d to ba49d5c Compare July 19, 2022 02:05

openyurt-bot assigned zyjhtangtang Jul 21, 2022

Congrool mentioned this pull request Jul 22, 2022

clean redundant lint in makefile #927

Merged

add proposal of daemosnet update model

9ff0305

Signed-off-by: hxcGit <[email protected]>

xavier-hou force-pushed the proposal-workload-update-model branch from ba49d5c to 9ff0305 Compare July 25, 2022 09:40

huangyuqi reviewed Jul 26, 2022

View reviewed changes

docs/proposals/20220718-workload-update-model.md Show resolved Hide resolved

huangyuqi reviewed Jul 26, 2022

View reviewed changes

docs/proposals/20220718-workload-update-model.md Show resolved Hide resolved

xavier-hou force-pushed the proposal-workload-update-model branch from 3188c7d to e8b79d2 Compare August 1, 2022 05:02

modify restAPI format

862cc23

Signed-off-by: hxcGit <[email protected]>

xavier-hou force-pushed the proposal-workload-update-model branch from e8b79d2 to 862cc23 Compare August 1, 2022 08:21

update annotation for auto upgrade model

4119405

Signed-off-by: hxcGit <[email protected]>

kadisi reviewed Aug 2, 2022

View reviewed changes

docs/proposals/20220718-workload-update-model.md Show resolved Hide resolved

kadisi reviewed Aug 2, 2022

View reviewed changes

rambohe-ch approved these changes Aug 2, 2022

View reviewed changes

openyurt-bot added approved approved lgtm lgtm labels Aug 2, 2022

openyurt-bot merged commit fa083f8 into openyurtio:master Aug 2, 2022

xavier-hou mentioned this pull request Aug 26, 2022

add auto pod upgrade controller for daemoset #970

Merged

rambohe-ch mentioned this pull request Aug 30, 2022

OSPP 2022: Edge application update model in cloud-edge collaboration architecture #914

Closed

xavier-hou mentioned this pull request Sep 14, 2022

add ota update RESTful API #1004

Merged

rambohe-ch changed the title ~~[Proposal] add proposal of daemosnet update model~~ [Proposal] add proposal of daemonset update model Nov 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Proposal] add proposal of daemonset update model #921

[Proposal] add proposal of daemonset update model #921

xavier-hou commented Jul 19, 2022

openyurt-bot commented Jul 19, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

codecov bot commented Jul 19, 2022 •

edited

Loading

rambohe-ch commented Jul 20, 2022

rambohe-ch commented Jul 21, 2022

rambohe-ch commented Jul 25, 2022 •

edited

Loading

rambohe-ch commented Jul 26, 2022

kadisi commented Jul 26, 2022

rambohe-ch commented Jul 27, 2022

rambohe-ch commented Jul 28, 2022

xavier-hou commented Jul 29, 2022

xavier-hou commented Jul 29, 2022

rambohe-ch commented Aug 1, 2022

xavier-hou commented Aug 1, 2022

kadisi commented Aug 2, 2022

kadisi left a comment

rambohe-ch commented Aug 2, 2022

kadisi commented Aug 2, 2022

rambohe-ch commented Aug 2, 2022

kadisi commented Aug 2, 2022

openyurt-bot commented Aug 2, 2022

[Proposal] add proposal of daemonset update model #921

[Proposal] add proposal of daemonset update model #921

Conversation

xavier-hou commented Jul 19, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

openyurt-bot commented Jul 19, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

codecov bot commented Jul 19, 2022 • edited Loading

Codecov Report

rambohe-ch commented Jul 20, 2022

rambohe-ch commented Jul 21, 2022

rambohe-ch commented Jul 25, 2022 • edited Loading

rambohe-ch commented Jul 26, 2022

kadisi commented Jul 26, 2022

rambohe-ch commented Jul 27, 2022

rambohe-ch commented Jul 28, 2022

xavier-hou commented Jul 29, 2022

xavier-hou commented Jul 29, 2022

rambohe-ch commented Aug 1, 2022

xavier-hou commented Aug 1, 2022

kadisi commented Aug 2, 2022

kadisi left a comment

Choose a reason for hiding this comment

rambohe-ch commented Aug 2, 2022

kadisi commented Aug 2, 2022

rambohe-ch commented Aug 2, 2022

kadisi commented Aug 2, 2022

openyurt-bot commented Aug 2, 2022

codecov bot commented Jul 19, 2022 •

edited

Loading

rambohe-ch commented Jul 25, 2022 •

edited

Loading