Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ota update RESTful API #1004

Merged
merged 10 commits into from
Sep 30, 2022
Merged

Conversation

xavier-hou
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

add ota pod update REST API

  1. GET /openyurt.io/v1/pods
  2. POST /openyurt.io/v1/namespaces/{ns}/pods/{podname}/update

Which issue(s) this PR fixes:

Related proposal #921

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot openyurt-bot added the do-not-merge/work-in-progress do-not-merge/work-in-progress label Sep 14, 2022
@openyurt-bot
Copy link
Collaborator

@xavier-hou: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

add ota pod update REST API

  1. GET /openyurt.io/v1/pods
  2. POST /openyurt.io/v1/namespaces/{ns}/pods/{podname}/update

Which issue(s) this PR fixes:

Related proposal #921

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #1004 (100f17a) into master (ba10718) will increase coverage by 0.10%.
The diff coverage is 54.12%.

@@            Coverage Diff             @@
##           master    #1004      +/-   ##
==========================================
+ Coverage   47.60%   47.71%   +0.10%     
==========================================
  Files          89       90       +1     
  Lines       12548    12651     +103     
==========================================
+ Hits         5974     6036      +62     
- Misses       6059     6093      +34     
- Partials      515      522       +7     
Flag Coverage Δ
unittests 47.71% <54.12%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/yurthub/server/server.go 0.00% <0.00%> (ø)
pkg/yurthub/otaupdate/ota.go 57.84% <57.84%> (ø)
.../daemonpodupdater/daemon_pod_updater_controller.go 39.39% <0.00%> (+1.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xavier-hou xavier-hou marked this pull request as ready for review September 26, 2022 00:48
@xavier-hou xavier-hou changed the title [WIP] add ota update RESTful API add ota update RESTful API Sep 26, 2022
@openyurt-bot openyurt-bot removed the do-not-merge/work-in-progress do-not-merge/work-in-progress label Sep 26, 2022
@zyjhtangtang
Copy link
Contributor

Are pods allowed to be updated when the cloud edge is disconnected?

@rambohe-ch
Copy link
Member

@xavier-hou please fix unit tests error

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, xavier-hou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Sep 30, 2022
@openyurt-bot openyurt-bot merged commit 7d3abf9 into openyurtio:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants