Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add auto pod upgrade controller for daemoset #970

Merged
merged 11 commits into from
Sep 27, 2022

Conversation

xavier-hou
Copy link
Member

Signed-off-by: hxcGit [email protected]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

#921

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@HXCGIT: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Signed-off-by: hxcGit [email protected]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

#921

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the do-not-merge/work-in-progress do-not-merge/work-in-progress label Aug 26, 2022
@openyurt-bot openyurt-bot added the size/XL size/XL: 500-999 label Aug 26, 2022
@xavier-hou xavier-hou changed the title add auto pod upgrade controller for daemoset [WIP]add auto pod upgrade controller for daemoset Aug 26, 2022
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #970 (b1d4411) into master (83d0d2d) will increase coverage by 3.55%.
The diff coverage is 50.46%.

@@            Coverage Diff             @@
##           master     #970      +/-   ##
==========================================
+ Coverage   44.04%   47.59%   +3.55%     
==========================================
  Files          83       89       +6     
  Lines       11346    12548    +1202     
==========================================
+ Hits         4997     5972     +975     
- Misses       5913     6060     +147     
- Partials      436      516      +80     
Flag Coverage Δ
unittests 47.59% <50.46%> (+3.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../daemonpodupdater/daemon_pod_updater_controller.go 38.02% <38.02%> (ø)
...er/daemonpodupdater/kubernetes/controller_utils.go 52.38% <52.38%> (ø)
pkg/controller/daemonpodupdater/util.go 70.50% <70.50%> (ø)
...controller/daemonpodupdater/kubernetes/pod_util.go 78.12% <78.12%> (ø)
pkg/yurtctl/util/kubernetes/util.go 20.00% <0.00%> (-12.17%) ⬇️
pkg/yurthub/cachemanager/cache_agent.go 49.27% <0.00%> (-5.28%) ⬇️
pkg/yurthub/filter/approver.go 75.65% <0.00%> (ø)
pkg/yurthub/network/iptables.go 0.00% <0.00%> (ø)
pkg/yurthub/certificate/hubself/fake_cert_mgr.go 0.00% <0.00%> (ø)
pkg/yurthub/certificate/hubself/cert_mgr.go 20.04% <0.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member

@HXCGIT please fix the errors of github actions.

@rambohe-ch
Copy link
Member

@HXCGIT we should consider the name of controller carefully. and i think podupgrade for newly added controller is not a good name.

@xavier-hou
Copy link
Member Author

@HXCGIT we should consider the name of controller carefully. and i think podupgrade for newly added controller is not a good name.

Yes, it's just a temporary name.

@xavier-hou xavier-hou force-pushed the feat-podUpgradeController branch 2 times, most recently from ba284f0 to dab0553 Compare August 29, 2022 01:14
@openyurt-bot openyurt-bot added size/XXL and removed size/XL size/XL: 500-999 labels Aug 29, 2022
@openyurt-bot openyurt-bot added size/XL size/XL: 500-999 and removed size/XXL labels Aug 29, 2022
@openyurt-bot openyurt-bot added size/XXL and removed size/XL size/XL: 500-999 labels Aug 30, 2022
@xavier-hou xavier-hou marked this pull request as ready for review September 1, 2022 08:43
@xavier-hou xavier-hou changed the title [WIP]add auto pod upgrade controller for daemoset add auto pod upgrade controller for daemoset Sep 1, 2022
@openyurt-bot openyurt-bot removed the do-not-merge/work-in-progress do-not-merge/work-in-progress label Sep 1, 2022
@xavier-hou xavier-hou force-pushed the feat-podUpgradeController branch 2 times, most recently from 2a4bb32 to 2444b6c Compare September 14, 2022 01:34
Signed-off-by: hxcGit <[email protected]>
Signed-off-by: Xuecheng <[email protected]>
@xavier-hou xavier-hou requested review from rambohe-ch and removed request for charleszheng44 and Fei-Guo September 20, 2022 03:26
@openyurt-bot openyurt-bot added the approved approved label Sep 27, 2022
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, xavier-hou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch rambohe-ch merged commit 98a21c7 into openyurtio:master Sep 27, 2022
lorrielau pushed a commit to lorrielau/openyurt that referenced this pull request Sep 30, 2022
* add auto pod upgrade controller for daemoset

Signed-off-by: hxcGit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants