-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add auto pod upgrade controller for daemoset #970
add auto pod upgrade controller for daemoset #970
Conversation
@HXCGIT: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #970 +/- ##
==========================================
+ Coverage 44.04% 47.59% +3.55%
==========================================
Files 83 89 +6
Lines 11346 12548 +1202
==========================================
+ Hits 4997 5972 +975
- Misses 5913 6060 +147
- Partials 436 516 +80
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@HXCGIT please fix the errors of github actions. |
@HXCGIT we should consider the name of controller carefully. and i think |
Yes, it's just a temporary name. |
ba284f0
to
dab0553
Compare
dab0553
to
1f7c3e3
Compare
Signed-off-by: hxcGit <[email protected]>
1f7c3e3
to
808c9c6
Compare
Signed-off-by: hxcGit <[email protected]>
Signed-off-by: hxcGit <[email protected]>
2a4bb32
to
2444b6c
Compare
Signed-off-by: hxcGit <[email protected]> Signed-off-by: Xuecheng <[email protected]>
2444b6c
to
6055449
Compare
pkg/controller/daemonpodupdater/daemon_pod_updater_controller.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Xuecheng <[email protected]>
Signed-off-by: hxcGit <[email protected]>
pkg/controller/daemonpodupdater/daemon_pod_updater_controller.go
Outdated
Show resolved
Hide resolved
Signed-off-by: hxcGit <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, xavier-hou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* add auto pod upgrade controller for daemoset Signed-off-by: hxcGit <[email protected]>
Signed-off-by: hxcGit [email protected]
What type of PR is this?
What this PR does / why we need it:
#921
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note