Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate dependency on k8s.io/kubernetes #453

Closed
SataQiu opened this issue Sep 6, 2021 · 7 comments · Fixed by #621
Closed

Eliminate dependency on k8s.io/kubernetes #453

SataQiu opened this issue Sep 6, 2021 · 7 comments · Fixed by #621
Labels
kind/bug kind/bug kind/good-first-issue kind/good-first-issue

Comments

@SataQiu
Copy link
Member

SataQiu commented Sep 6, 2021

https://github.com/kubernetes/kubernetes#to-start-using-k8s

Use of the k8s.io/kubernetes module or k8s.io/kubernetes/... packages as libraries is not supported.

Relying directly on k8s.io/kubernetes didn't seem like a good idea, which made our project difficult to upgrade and maintain. I propose that eliminate dependency on k8s.io/kubernetes.

This is likely to be a long-term task.

@SataQiu SataQiu added the kind/bug kind/bug label Sep 6, 2021
@SataQiu
Copy link
Member Author

SataQiu commented Sep 6, 2021

/kind cleanup

@openyurt-bot
Copy link
Collaborator

@SataQiu: The label(s) kind/cleanup cannot be applied, because the repository doesn't have them

In response to this:

/kind cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rambohe-ch
Copy link
Member

@SataQiu Thank you for filing issue.
It's a good idea to cleanup dependency on k8s.io/kubernetes in openyurt. and would you like to take over this work?

@SataQiu
Copy link
Member Author

SataQiu commented Sep 6, 2021

@rambohe-ch
I'd like to help with this.
It seems a big job, and more contributors are welcome!
/kind good-first-issue

@openyurt-bot
Copy link
Collaborator

@SataQiu: The label(s) kind/ cannot be applied, because the repository doesn't have them

In response to this:

@rambohe-ch
I'd like to help with this.
It seems a big job, and more contributors are welcome!
/kind good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/good-first-issue kind/good-first-issue label Sep 6, 2021
@rambohe-ch
Copy link
Member

@rambohe-ch
I'd like to help with this.
It seems a big job, and more contributors are welcome!
/kind good-first-issue

@SataQiu It seems that yurt-controller-manager, yurtctl, yurt-tunnel have imported k8s.io/kubernetes, we can cleanup the dependency from yurt-tunnel --> yurtctl --> yurt-controller-manager.

@rambohe-ch
Copy link
Member

This issue is divided into issue #548 #549 #550 #551 , so this issue can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug kind/bug kind/good-first-issue kind/good-first-issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants