Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request]Remove k8s.io/kubernetes dependency for yurt-controller-manager #549

Closed
rambohe-ch opened this issue Nov 2, 2021 · 7 comments · Fixed by #644
Closed
Labels
help wanted help wanted kind/feature kind/feature kind/good-first-issue kind/good-first-issue

Comments

@rambohe-ch
Copy link
Member

What would you like to be added:
Yurt-controller-manager have imported k8s.io/kubernetes, you can search k8s.io/kubernetes in cmd/yurt-controller-manager and pkg/controller directory. and based on Issue #453, we need to remove k8s.io/kubernetes dependency.

Why is this needed:
From kubernetes introduction: https://github.com/kubernetes/kubernetes#to-start-using-k8s

To use Kubernetes code as a library in other applications, see the list of published components. Use of the k8s.io/kubernetes module or k8s.io/kubernetes/... packages as libraries is not supported.

others
/kind feature

@rambohe-ch rambohe-ch added help wanted help wanted kind/good-first-issue kind/good-first-issue kind/feature kind/feature labels Nov 2, 2021
@hzliangbin
Copy link

/assign

@hzliangbin
Copy link

@rambohe-ch hi, what should I do is to replace k8s.io/kubernetes with dependencies listed here . right?

@rambohe-ch
Copy link
Member Author

rambohe-ch commented Nov 2, 2021

@rambohe-ch hi, what should I do is to replace k8s.io/kubernetes with dependencies listed here . right?

@hzliangbin yes, we can use k8s.io/kube-controller-manager directly for yurt-controller-manager.
and if no dependency library can be imported, maybe we need move the original code into OpenYurt.

@rambohe-ch
Copy link
Member Author

@hzliangbin Would you be able to update progress about this issue?

@hzliangbin
Copy link

hzliangbin commented Dec 1, 2021

@rambohe-ch

so sorry for being late, i will open a pr in a day or two.

@rambohe-ch
Copy link
Member Author

@rambohe-ch

so sorry for being late, i will open a pr in a day or two.

@hzliangbin Thanks for your feedback.
I'am very sorry, other community member had taken over this issue and he will make a pull request today. how about to review the pull request as reviewer?

@hzliangbin
Copy link

@rambohe-ch
so sorry for being late, i will open a pr in a day or two.

@hzliangbin Thanks for your feedback. I'am very sorry, other community member had taken over this issue and he will make a pull request today. how about to review the pull request as reviewer?

@rambohe-ch I'd love to, but I am a new bird to openyurt so I'm afraid that I can't give a hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted help wanted kind/feature kind/feature kind/good-first-issue kind/good-first-issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants