Remove k8s.io/kubernetes dependency for yurt-controller-manager #644
Conversation
|
@qclc: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
qclc
force-pushed
the
remove-controller-dependency
branch
2 times, most recently
from
eaf95e4 to
2a89bd3
Compare
go.mod
Outdated
| k8s.io/klog/v2 v2.4.0 | ||
| k8s.io/component-base v0.22.4 | ||
| k8s.io/controller-manager v0.22.4 | ||
| k8s.io/klog v1.0.0 |
| @@ -0,0 +1,80 @@ | |||
| /* | |||
There was a problem hiding this comment.
please import helper.go from k8s.io/controller-manager
There was a problem hiding this comment.
The k8s.io/controller-manager only supports version 1.20.x or later. The current policy is to cache the used k8s.io/kubernetes/pkg/controller files. After openYurt is upgraded to version 1.20.x, I will submit a PR to replace k8s.io/kubernetes/pkg/controller with k8s.io/controller-manager.
| @@ -0,0 +1,47 @@ | |||
| /* | |||
There was a problem hiding this comment.
please import types.go from k8s.io/kube-controller-manager
There was a problem hiding this comment.
The k8s.io/controller-manager only supports version 1.20.x or later. The current policy is to cache the used k8s.io/kubernetes/pkg/controller files. After openYurt is upgraded to version 1.20.x, I will submit a PR to replace k8s.io/kubernetes/pkg/controller with k8s.io/controller-manager.
qclc
force-pushed
the
remove-controller-dependency
branch
from
2a89bd3 to
c722439
Compare
qclc
force-pushed
the
remove-controller-dependency
branch
from
c722439 to
a654be5
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qclc, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
openyurt/pkg/controller/kubernetespathWhich issue(s) this PR fixes:
Fixes #549
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note