Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request]Remove k8s.io/kubernetes dependency for yurtctl #550

Closed
rambohe-ch opened this issue Nov 2, 2021 · 8 comments · Fixed by #681
Closed

[feature request]Remove k8s.io/kubernetes dependency for yurtctl #550

rambohe-ch opened this issue Nov 2, 2021 · 8 comments · Fixed by #681
Assignees
Labels
help wanted help wanted kind/feature kind/feature kind/good-first-issue kind/good-first-issue

Comments

@rambohe-ch
Copy link
Member

What would you like to be added:
Yurtctl have imported k8s.io/kubernetes, you can search k8s.io/kubernetes in pkg/yurtctl directory. and based on Issue #453, we need to remove k8s.io/kubernetes dependency.

Why is this needed:
From kubernetes introduction: https://github.com/kubernetes/kubernetes#to-start-using-k8s

To use Kubernetes code as a library in other applications, see the list of published components. Use of the k8s.io/kubernetes module or k8s.io/kubernetes/... packages as libraries is not supported.

others
/kind feature

@rambohe-ch rambohe-ch added help wanted help wanted kind/good-first-issue kind/good-first-issue kind/feature kind/feature labels Nov 2, 2021
@villanel
Copy link
Member

villanel commented Nov 2, 2021

/assign

@Peeknut
Copy link
Member

Peeknut commented Nov 30, 2021

yurtctl join, yurtctl init reuses a lot of code in kubeadm, and it takes a lot of work to delete dependencies directly and rewriting the code. How about download and use the kubeadm binary file directly in yurtctl?

@rambohe-ch
Copy link
Member Author

it takes a lot of work to delete dependencies directly and rewriting the code. How about download and use the kubeadm binary file directly in yurtctl?

@Peeknut It's a good idea to use kubeadm binary directly. agree +1

@villanel
Copy link
Member

There are two parts to be replaced here,kubelet and kubeadm, I will try to use the kubeadm binary file directly.

@rambohe-ch
Copy link
Member Author

There are two parts to be replaced here,kubelet and kubeadm, I will try to use the kubeadm binary file directly.

@villanel Thank you for your reply. Do you have any progress of this enhancement?
and we want to solve this feature in these days, then we can go ahead to update OpenYurt other dependencies.

@villanel
Copy link
Member

@rambohe-ch Thank you for your help, I will finish this part as soon as possible.

@villanel
Copy link
Member

villanel commented Dec 1, 2021

@rambohe-ch It seems kubeadm binary file has many test cases and unused code, should we keep these?

@rambohe-ch
Copy link
Member Author

@rambohe-ch It seems kubeadm binary file has many test cases and unused code, should we keep these?

@villanel we can download kubeadm binary like download other components(eg: kubelet), and use the downloaded kubeadm binary by cmd.exec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted help wanted kind/feature kind/feature kind/good-first-issue kind/good-first-issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants