Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request]Refactor yurtctl join to remove k8s.io/kubernetes dependency #671

Closed
Peeknut opened this issue Dec 10, 2021 · 4 comments · Fixed by #697
Closed

[feature request]Refactor yurtctl join to remove k8s.io/kubernetes dependency #671

Peeknut opened this issue Dec 10, 2021 · 4 comments · Fixed by #697
Assignees
@rambohe-ch
Labels
kind/feature kind/feature kind/good-first-issue kind/good-first-issue

Comments

@Peeknut
Copy link
Member

Peeknut commented Dec 10, 2021 •
edited
Loading

What would you like to be added:
yurtctl join references k8s.io/kubernetes dependencies, especially k8s.io/kubernetes/cmd/kubeadm, maybe we should refactor to remove the dependencies.

yurtctl join can be divided into the following steps:

  1. preflightcheck: check the necessary configuration for cluster operation, such as the pull of necessary images, the installation of kubelet.
  2. start kubelet
  3. start yurthub

Why is this needed:
We can remove the dependency of k8s.io/kubernetes in yurtctl join .(issue: #550 )

others
/kind feature
/kind good-first-issue
@Peeknut Peeknut added the kind/feature kind/feature label Dec 10, 2021
@openyurt-bot openyurt-bot added the kind/good-first-issue kind/good-first-issue label Dec 10, 2021
@neo502721
Copy link
Member

Can you assign to me?

@Peeknut
Copy link
Member Author

Peeknut commented Dec 22, 2021

Sorry, it seems that @rambohe-ch is already responsible for this problem.

@rambohe-ch
Copy link
Member

Can you assign to me?

@neo502721 Thank you for your responsibility, and i will make a pull request soon, I hope you will participate in code review.

@rambohe-ch
Copy link
Member

/assign @rambohe-ch

@rambohe-ch rambohe-ch mentioned this issue Dec 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rambohe-ch rambohe-ch

Labels
kind/feature kind/feature kind/good-first-issue kind/good-first-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove k8s.io/kubernetes dependency from yurtctl join/reset rambohe-ch/openyurt
4 participants
@neo502721 @Peeknut @rambohe-ch @openyurt-bot