-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement GitHub Actions for lint and buildAndTest #49
Conversation
Addressed feedback. Actions job with the new changes is running on https://github.com/GleasonK/stablehlo/actions. Let's wait for that before any accept/merge is made. Edit: Tests all passed in gleasonk/stablehlo actions. |
Rebased on main. Should be good for final review / merge. Please wait for the actions job on my forked repo to complete successfully before merge, the lint action already passed: |
Edit: GH Actions job passed. Only took 4m 53s with caching, not bad. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the PR description to reword "We can consider only running buildAndTest on linux in the future, mac is a bit of a redundancy, but will help us distinguish a real failure from a build configuration issue in GH Actions".
Initial implementation of GitHub Actions CI. This changelist implements two actions:
Build & Test:
llvm_version.txt
ninja check-stablehlo
Lint:
git-clang-format
on the files being submitted.Examples of what the CI page will look like can be seen at: https://github.com/GleasonK/stablehlo/actions
Future work:
Closes #12