Define code style

[burmako]

Currently, StableHLO doesn't have a formally-defined code style, but it will be good to have one. We could start with inheriting MLIR-HLO's code style to maximize familiarity for existing CHLO/MHLO users.

[bhack]

We will need a code style also for #32

[jpienaar]

Note: CHLO/MHLO has mixed code style (which would be good to rectify). I'd say adopting either MLIR's style guide or Google's style guide (C++ side, Python side MLIR doesn't have en explicit one but close to Google's Python one in practice) would allow most familiarity. With the former being more consistent for end to end. (Builders and the like could also follow different style but that ends up being confusing).

[burmako]

Further questions to handle when defining code style, via jpienaar's review of a recent PR:

• Use of doxygen and which constructs or conventions are followed (comment).
• Error conventions (comment).

[burmako]

The last two weeks have been pretty hectic as we've been bootstrapping a GitHub-centric StableHLO development process from the Google-centric MLIR-HLO development process. During that time, we have set up the basic infrastructure (pull requests, issues, CI) and are almost done setting up regular integrates from StableHLO into MLIR-HLO.

I anticipate that we'll get to defining code style fairly soon (within the next 1-2 weeks).

In the meantime, @GleasonK has set up a CI check with runs git-clang-format (#49) and opened a ticket to also run clang-tidy likely bootstrapping it from MLIR-HLO (#61). In #76, @joker-eph has explored what it would take to switch the codebase from Google's clang-format style that our codebase currently follows to LLVM's clang-format style.

[burmako]

Another part of code style is Markdown formatting. Let's find a formatter / linter, so that we can automate changes like #128. (Also see Kevin's comment in that PR).

[sdasgup3]

Regarding formatting markdowns: Adding links to the markdown might break the 80 lines constraint. The script can ignore those.

[burmako]

We're getting closer to the point when all the urgent work is done (e.g. our code now ships as part of MLIR-HLO which is great, but we still need an RFC process which is blocking quite a few things), at which point I'm planning to write something up about this.

One more item to comment on in the code style style is commit messages. Here's MLIR's guidance about this (thank you, Mehdi, for the link!): https://mlir.llvm.org/getting_started/Contributing/#commit-messages.

[burmako]

The linked pull request contributed to defining code style (or, more precisely, codifying a baseline that we'll build on), but this ticket is far from being resolved at this point :) Reopening.

[GleasonK]

Good catch. The phrasing "should resolve <issue> soon" from that PR falls under the words to link/close an issue.

[GleasonK]

Another part of code style is Markdown formatting.

@scottamain has been looking into this recently: #795, #792, #793, #729