-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clang-tidy to Github Actions #61
Comments
Started looking into this, and a few notes: There are quite a few git diff -U0 HEAD^ | clang-tidy-diff.py -p1 -path /path/to/stablehlo-build/ Second it seems like Third, maybe someone more familiar with This raises the question - how often would we want to run this test? Every PR? If running serially is required, then each update to a PR (even if ccached) may trigger 20+min of actions. I can run these tests in my fork for a bit and get a feel for the overhead. |
Did some testing last week in actions-tidy branch. The CI environment does not seem to work well with clang-tidy (ref). This trace makes me think it is a configuration issue more than anything. I'll try a few more things like building clang-tidy from llvm source in CI, or installing a different version via package management and running that. |
Unassigning for now. I hope to get to this in the near future, but this has lower priority than compatibility work, as well as some other early-stage proposals in the works. |
Manually fixing as part of clang-tidy check which is currently not supported in StableHLO #61
Manually fixing as part of clang-tidy check which is currently not supported in StableHLO openxla#61
Request description
From feedback in #49 - Add a
clang-tidy
task to the lint action.Can be bootstrapped from MHLO:
https://github.com/tensorflow/mlir-hlo/blob/master/.clang-tidy
Additional context
No response
The text was updated successfully, but these errors were encountered: