Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Py OV] Remove imports of openvino.runtime from openvino module #27479
[Py OV] Remove imports of openvino.runtime from openvino module #27479
Changes from 24 commits
718a304
c1efcfe
453c6cb
c5f2433
546135d
46fa069
d9fd073
1b93b12
9bd8066
9cd78da
f696c52
2e5a21a
de844f3
0da0df9
3adfe5c
55d8038
e0c86e9
ffa6953
037bcb0
9142a63
bb03585
b65f2d6
8d49825
dfa5172
fb52f7a
8f878e5
1645918
05796c4
ea1f084
83f4dde
6e857a1
9141747
e302e69
82cce8e
fa1416a
f05ff74
3e91a36
a2972ea
3f944ec
ff00a3d
c07d4bd
39fcfa6
6cf7779
ce8c32d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any logic why some API is in ie_api, while others in _pyopenvino ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
the ones which are imported from
.ie_api
havepython wrappers
above original binded classes from._pyopenvino
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, but why then it's called ie_api ? better name is requried IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just legacy internal stuff :)
Ok, we will consider a better name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. _pyopenvino_legacy or _pyopenvino.legacy....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mryzhov the name
ie_api
is legacy, the file itself contains pretty necessary and state-of-the-art code :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed to
_ov_api.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the name of openvino/runtime/ie.api.py shouldn't be renamed in case somebody is using it (even though it's internal)