Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Py OV] Remove imports of openvino.runtime from openvino module #27479

Closed
wants to merge 44 commits into from
Closed

[Py OV] Remove imports of openvino.runtime from openvino module #27479

wants to merge 44 commits into from

Conversation

almilosz
Copy link
Contributor

@almilosz almilosz commented Nov 8, 2024 •
edited
Loading

Details:

Remove openvino.runtime imports from python/src/openvino that unnecessary trigger the warning

  • move ie_api.py, exceptions.py up to python/src/openvino
  • move runtime/utils/ to python/src/openvino.
  • rename openvino/utils.py to openvnio/package_utils.py
  • move op/, opsetX and opset_utils.py to python/src/openvino/
  • keep in the runtime the file structure and aliases

Tickets:

almilosz added 14 commits November 4, 2024 12:18
@almilosz
Add deprecation warning to runtime module __init__
718a304 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
Update msg
c1efcfe 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
Update msg
453c6cb 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
Comment out runtime import
c5f2433 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
Move *.py files up
546135d 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
Add aliases for opset and fix imports in opsets
46fa069 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
Move and add alias for exceptions
d9fd073 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
Add aliases for exceptions and utils
1b93b12 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
Update openvino/utils
9bd8066 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
Mv utils.py to ultils/__init__
9cd78da 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
Update openvino/files
f696c52 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
Restore file structure in runtime/ and remove openvino/opsets/ dir
2e5a21a 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
Fix codestyle
de844f3 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
Add empty lines
0da0df9 
Signed-off-by: Alicja Miloszewska <[email protected]>
@github-actions github-actions bot added category: Python API OpenVINO Python bindings category: tools OpenVINO C++ / Python tools category: TF FE OpenVINO TensorFlow FrontEnd category: PyTorch FE OpenVINO PyTorch Frontend category: JAX FE OpenVINO JAX FrontEnd category: OVC OVC tool labels Nov 8, 2024
@almilosz
Merge branch 'master' of https://github.com/openvinotoolkit/openvino …
3adfe5c 
…into almilosz/ov-rt-deprecation-warn

Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
fixes after merge
55d8038 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
Add classes to ov.__init__
e0c86e9 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
Merge branch 'master' into almilosz/ov-rt-deprecation-warn
ffa6953
@almilosz
fix linters
037bcb0 
Signed-off-by: Alicja Miloszewska <[email protected]>
@akuporos
Copy link
Contributor

build_jenkins

@almilosz almilosz marked this pull request as ready for review November 13, 2024 08:50
@almilosz almilosz requested review from a team as code owners November 13, 2024 08:50
ilya-lavrenov
ilya-lavrenov reviewed Nov 19, 2024
View reviewed changes
src/bindings/python/src/openvino/runtime/__init__.py Outdated

warnings.warn(
"The `openvino.runtime` module is deprecated and will be removed in the 2026.0 release. "
"Please replace `openvino.runtime` with `openvino` after 25.1 release.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Please replace `openvino.runtime` with `openvino` after 25.1 release.",
"Please replace `openvino.runtime` with `openvino` after 2025.0 release.",

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the warning to a separate PR. Let's discuss the final form of the message and when warning should be shown there

akuporos
akuporos requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@akuporos akuporos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check other tools/ovc files and make import from openvino, not from openvino._pyopenvino.
Or keep imports from openvino.runtime and let's update import there by separate PR to reduce the number of changed files in this PR.

@almilosz
Remove direct imports from ie_api.py
e302e69 
Signed-off-by: Alicja Miloszewska <[email protected]>
@github-actions github-actions bot removed the category: packaging OpenVINO packaging / distribution label Nov 19, 2024
@almilosz
Replace .. with os.pardir
fa1416a 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
Rename build_utils.py to package_utils.py
f05ff74 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
Add LazyLoader for runtime
3e91a36 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
Load fixes
a2972ea 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
Rename openvino/ie_api.py to _ov_api.py
3f944ec 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz
Update tools/ovc
ff00a3d 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz almilosz changed the title [Py OV] Add deprecation warning for runtime module [Py OV] Remove imports of openvino.runtime from openvino module Nov 22, 2024
@almilosz
remove warning
c07d4bd 
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz almilosz mentioned this pull request Nov 22, 2024
Draft
@almilosz almilosz closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praasz praasz praasz left review comments

@mryzhov mryzhov mryzhov left review comments

@akuporos akuporos akuporos requested changes

@ilya-lavrenov ilya-lavrenov Awaiting requested review from ilya-lavrenov

Assignees
No one assigned
Labels
category: JAX FE OpenVINO JAX FrontEnd category: MO Model Optimizer category: OVC OVC tool category: Python API OpenVINO Python bindings category: PyTorch FE OpenVINO PyTorch Frontend category: TF FE OpenVINO TensorFlow FrontEnd category: tools OpenVINO C++ / Python tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@almilosz @akuporos @ilya-lavrenov @mryzhov @praasz