-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Py OV] Remove imports of openvino.runtime from openvino module #27479
Closed
almilosz
wants to merge
44
commits into
openvinotoolkit:master
from
almilosz:almilosz/ov-rt-deprecation-warn
Closed
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
718a304
Add deprecation warning to runtime module __init__
almilosz c1efcfe
Update msg
almilosz 453c6cb
Update msg
almilosz c5f2433
Comment out runtime import
almilosz 546135d
Move *.py files up
almilosz 46fa069
Add aliases for opset and fix imports in opsets
almilosz d9fd073
Move and add alias for exceptions
almilosz 1b93b12
Add aliases for exceptions and utils
almilosz 9bd8066
Update openvino/utils
almilosz 9cd78da
Mv utils.py to ultils/__init__
almilosz f696c52
Update openvino/files
almilosz 2e5a21a
Restore file structure in runtime/ and remove openvino/opsets/ dir
almilosz de844f3
Fix codestyle
almilosz 0da0df9
Add empty lines
almilosz 3adfe5c
Merge branch 'master' of https://github.com/openvinotoolkit/openvino …
almilosz 55d8038
fixes after merge
almilosz e0c86e9
Add classes to ov.__init__
almilosz ffa6953
Merge branch 'master' into almilosz/ov-rt-deprecation-warn
almilosz 037bcb0
fix linters
almilosz 9142a63
change imports
almilosz bb03585
Import Node from _pyopenvino
almilosz b65f2d6
Update relative paths in _add_openvino_libs_to_search_path()
almilosz 8d49825
Fix path for adding dll
almilosz dfa5172
Move _add_openvino_libs_to_search_path() up
almilosz fb52f7a
Move get_cmake_path
almilosz 8f878e5
Remove aliases
almilosz 1645918
Fix ie_api.Model import as attribute of openvino.runtime
almilosz 05796c4
Update mo and openvino_dev __init__s
almilosz ea1f084
Merge branch 'master' into almilosz/ov-rt-deprecation-warn
almilosz 83f4dde
Remove direct imports from _pyopenvino
almilosz 6e857a1
remove circular import and update ovc
almilosz 9141747
fix comment
almilosz e302e69
Remove direct imports from ie_api.py
almilosz 82cce8e
Merge branch 'master' into almilosz/ov-rt-deprecation-warn
almilosz fa1416a
Replace .. with os.pardir
almilosz f05ff74
Rename build_utils.py to package_utils.py
almilosz 3e91a36
Add LazyLoader for runtime
almilosz a2972ea
Load fixes
almilosz 3f944ec
Rename openvino/ie_api.py to _ov_api.py
almilosz ff00a3d
Update tools/ovc
almilosz c07d4bd
remove warning
almilosz 39fcfa6
Merge branch 'master' into almilosz/ov-rt-deprecation-warn
almilosz 6cf7779
Merge branch 'master' into almilosz/ov-rt-deprecation-warn
almilosz ce8c32d
Revert changes to tools/ovc/openvino/
almilosz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any logic why some API is in ie_api, while others in _pyopenvino ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
the ones which are imported from
.ie_api
havepython wrappers
above original binded classes from._pyopenvino
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, but why then it's called ie_api ? better name is requried IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just legacy internal stuff :)
Ok, we will consider a better name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. _pyopenvino_legacy or _pyopenvino.legacy....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mryzhov the name
ie_api
is legacy, the file itself contains pretty necessary and state-of-the-art code :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed to
_ov_api.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the name of openvino/runtime/ie.api.py shouldn't be renamed in case somebody is using it (even though it's internal)