Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue]: [OV JS] Add check for arguments to Tensor.getData() #27796

Closed
almilosz opened this issue Nov 28, 2024 · 5 comments · Fixed by #27843
Closed

[Good First Issue]: [OV JS] Add check for arguments to Tensor.getData() #27796

almilosz opened this issue Nov 28, 2024 · 5 comments · Fixed by #27843
Assignees
Labels
category: JS API OpenVino JS API Bindings good first issue Good for newcomers no_stale Do not mark as stale
Milestone

Comments

@almilosz
Copy link
Contributor

Context

Context

OpenVINO works in Node.js environment!
We are looking for new contributors who can help with enabling C++ API methods
in JavaScript side.

First of all read Node.js API Contribution Guide.

Task Details

The Tensor.getData() method, which takes no arguments, should return an error if an argument is passed.

What needs to be done?

How to take this issue

To take this issue leave text: .take as the comment in this issue.
It will assign this issue to you automatically. Please, make sure that the issue has the status Contributors Needed and doesn't have another user in Assingnees.

Example Pull Requests

Resources

Contact points

@almilosz @vishniakov-nikolai

Please, mention us in this issue discussion if you have any questions.

Ticket

@almilosz almilosz added good first issue Good for newcomers category: JS API OpenVino JS API Bindings no_stale Do not mark as stale labels Nov 28, 2024
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Nov 28, 2024
@Pranjal0901
Copy link

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@Pranjal0901
Copy link

which repo i have to download to implement this

@mlukasze
Copy link
Contributor

which repo i have to download to implement this

https://github.com/openvinotoolkit/openvino

@Manideep-Kanna
Copy link
Contributor

Hi, I have seen this issue been open for three days. Thought of working on it. I have raised a PR for these changes can you please look at them and let me know if additional changes are required.

@mlukasze mlukasze moved this from Contributors Needed to In Review in Good first issues Dec 2, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 11, 2024
…ut functionality (#27843)

This fixes #27796 
Implemented the exception for the passing parameter scenario for getData
function

- Added condition to check if parameters are passed or not
- Added tests in Tensor.test.js
@github-project-automation github-project-automation bot moved this from In Review to Closed in Good first issues Dec 11, 2024
@mlukasze mlukasze added this to the 2025.0 milestone Dec 12, 2024
11happy pushed a commit to 11happy/openvino that referenced this issue Dec 23, 2024
…ut functionality (openvinotoolkit#27843)

This fixes openvinotoolkit#27796 
Implemented the exception for the passing parameter scenario for getData
function

- Added condition to check if parameters are passed or not
- Added tests in Tensor.test.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: JS API OpenVino JS API Bindings good first issue Good for newcomers no_stale Do not mark as stale
Projects
Status: Closed
4 participants