-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Good First Issue]: [OV JS] Add check for arguments to Tensor.getData() #27796
Labels
category: JS API
OpenVino JS API Bindings
good first issue
Good for newcomers
no_stale
Do not mark as stale
Milestone
Comments
almilosz
added
good first issue
Good for newcomers
category: JS API
OpenVino JS API Bindings
no_stale
Do not mark as stale
labels
Nov 28, 2024
.take |
Thank you for looking into this issue! Please let us know if you have any questions or require any help. |
which repo i have to download to implement this |
|
Hi, I have seen this issue been open for three days. Thought of working on it. I have raised a PR for these changes can you please look at them and let me know if additional changes are required. |
11happy
pushed a commit
to 11happy/openvino
that referenced
this issue
Dec 23, 2024
…ut functionality (openvinotoolkit#27843) This fixes openvinotoolkit#27796 Implemented the exception for the passing parameter scenario for getData function - Added condition to check if parameters are passed or not - Added tests in Tensor.test.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: JS API
OpenVino JS API Bindings
good first issue
Good for newcomers
no_stale
Do not mark as stale
Context
Context
OpenVINO works in Node.js environment!
We are looking for new contributors who can help with enabling C++ API methods
in JavaScript side.
First of all read Node.js API Contribution Guide.
Task Details
The
Tensor.getData()
method, which takes no arguments, should return an error if an argument is passed.What needs to be done?
Tensor.getData()
method node/src/tensor.cpp#L69How to take this issue
To take this issue leave text:
.take
as the comment in this issue.It will assign this issue to you automatically. Please, make sure that the issue has the status Contributors Needed and doesn't have another user in Assingnees.
Example Pull Requests
Resources
Contact points
@almilosz @vishniakov-nikolai
Please, mention us in this issue discussion if you have any questions.
Ticket
The text was updated successfully, but these errors were encountered: