-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS API] Add config param to Core.import_model() #24023
Merged
mlukasze
merged 7 commits into
openvinotoolkit:master
from
almilosz:almilosz/import-model-config
Apr 18, 2024
Merged
[JS API] Add config param to Core.import_model() #24023
mlukasze
merged 7 commits into
openvinotoolkit:master
from
almilosz:almilosz/import-model-config
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishniakov-nikolai
requested changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to update definition of importModelSync
in addon.ts
vishniakov-nikolai
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 18, 2024
alvoron
pushed a commit
to alvoron/openvino
that referenced
this pull request
Apr 29, 2024
### Details: - add `Core.import_model(stream, device_name, config[optional}) - add ` ov::AnyMap to_anyMap(const Napi::Env&, const Napi::Value&)` helper for conversion from Napi::Value to ov::AnyMap and reuse it in other methods ### Tickets: - *136460*
This was referenced May 6, 2024
This was referenced Jul 5, 2024
This was referenced Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
ov::AnyMap to_anyMap(const Napi::Env&, const Napi::Value&)
helper for conversion from Napi::Value to ov::AnyMap and reuse it in other methodsTickets: