Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS API] Add config param to Core.import_model() #24023

Merged

Conversation

almilosz
Copy link
Contributor

Details:

  • add `Core.import_model(stream, device_name, config[optional})
  • add ov::AnyMap to_anyMap(const Napi::Env&, const Napi::Value&) helper for conversion from Napi::Value to ov::AnyMap and reuse it in other methods

Tickets:

  • 136460

@almilosz almilosz requested a review from a team as a code owner April 15, 2024 07:46
@github-actions github-actions bot added the category: JS API OpenVino JS API Bindings label Apr 15, 2024
Copy link
Contributor

@vishniakov-nikolai vishniakov-nikolai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to update definition of importModelSync in addon.ts

src/bindings/js/node/src/core_wrap.cpp Show resolved Hide resolved
Copy link
Contributor

@vishniakov-nikolai vishniakov-nikolai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishniakov-nikolai vishniakov-nikolai added this pull request to the merge queue Apr 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 18, 2024
@mlukasze mlukasze added this pull request to the merge queue Apr 18, 2024
Merged via the queue into openvinotoolkit:master with commit cac2777 Apr 18, 2024
107 checks passed
alvoron pushed a commit to alvoron/openvino that referenced this pull request Apr 29, 2024
### Details:
 - add `Core.import_model(stream, device_name, config[optional})
- add ` ov::AnyMap to_anyMap(const Napi::Env&, const Napi::Value&)`
helper for conversion from Napi::Value to ov::AnyMap and reuse it in
other methods

### Tickets:
 - *136460*
@almilosz almilosz deleted the almilosz/import-model-config branch July 18, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: JS API OpenVino JS API Bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants