Fix#27796 Added condition and test case for the getData parameter input functionality #27843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manideep-Kanna
changed the title
almilosz
reviewed
Dec 2, 2024
src/bindings/js/node/src/tensor.cpp
Outdated
| Napi::Env env = info.Env(); | ||
| if (info.Length() > 0) { | ||
| reportError(env, "getData() does not accept any arguments."); | ||
| return env.Undefind |
There was a problem hiding this comment.
Suggested change
| return env.Undefind | |
| return env.Undefined(); |
There was a problem hiding this comment.
Hi @almilosz, thank you for pointing out the issue. Sorry, I forgot to push the commit. Doing the push right now. Can you please review it.
almilosz
reviewed
Dec 3, 2024
src/bindings/js/node/src/tensor.cpp
Outdated
| Napi::Env env = info.Env(); | ||
| if (info.Length() > 0) { | ||
| reportError(env, "getData() does not accept any arguments."); | ||
| return env.Undefined() |
There was a problem hiding this comment.
Suggested change
| return env.Undefined() | |
| return env.Undefined(); |
there is a semicolon missing ;) I recommend checking git status carefully, building the project and running tests before pushing changes
There was a problem hiding this comment.
Done @almilosz
almilosz
approved these changes
Dec 10, 2024
|
build_jenkins |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
11happy
pushed a commit
to 11happy/openvino
that referenced
this pull request
Dec 23, 2024
…ut functionality (openvinotoolkit#27843) This fixes openvinotoolkit#27796 Implemented the exception for the passing parameter scenario for getData function - Added condition to check if parameters are passed or not - Added tests in Tensor.test.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #27796
Implemented the exception for the passing parameter scenario for getData function