Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use DataPlaneService.DataSources" #850

Closed
wants to merge 1 commit into from
Closed

Revert "Use DataPlaneService.DataSources" #850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions scripts/gen-nova-custom-dataplane-service.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,9 @@ cat <<EOF >>kustomization.yaml
path: /metadata/name
value: nova-custom
- op: add
path: /spec/dataSources
path: /spec/configMaps
value:
- configMapRef:
name: nova-extra-config
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the reason this is problematic is this si removing the the ssh-key and cell secreate as it s a direct replacement of the list.

so what ti might have to do instead of the revert is a patch to hanel that proerply which I'm going to work on as a third option.
then when we change ci results for all 3 we can decide how to proceed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im hoping we can proceed with #851 instead and i can abandon this if that works

- nova-extra-config
EOF

# Create the nova-extra-config CM based on the provided config file
Expand Down