Test samples from inline docs #769
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fao89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/c2a55b20f5694f4b9ca5e87d3e513387 ❌ openstack-k8s-operators-content-provider FAILURE in 10m 01s |
|
/test dataplane-operator-build-deploy-kuttl |
|
recheck |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/f3c4c7fb709a4b05a78f17d9391c8677 ❌ openstack-k8s-operators-content-provider FAILURE in 9m 33s |
|
recheck |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/e715f151065e4e03bdb48e9a2438e22c ❌ openstack-k8s-operators-content-provider FAILURE in 9m 26s |
fao89
changed the title
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/4d0da4a22ed8470abcc83f6f4e7cd762 ✔️ openstack-k8s-operators-content-provider SUCCESS in 38m 48s |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/45157f206968446bbd85777b39a27e68 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 53m 20s |
|
/test dataplane-operator-build-deploy-kuttl |
|
/test dataplane-operator-build-deploy-kuttl |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/53367bfbf45e4c9fbebf1fe49c63a967 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 28s |
|
/test dataplane-operator-build-deploy-kuttl |
|
/test dataplane-operator-build-deploy-kuttl |
|
/test dataplane-operator-build-deploy-kuttl |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/dfdce514455647a997a6d19b2ec7fc0c ❌ openstack-k8s-operators-content-provider FAILURE in 8m 13s |
fao89
force-pushed
the
inlinesamples
branch
2 times, most recently
from
e8dc8c0 to
cdb8e05
Compare
|
/test dataplane-operator-build-deploy-kuttl |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/e57cd55d34554ff69d7425533ae9b68a ❌ openstack-k8s-operators-content-provider FAILURE in 7m 56s |
|
/test dataplane-operator-build-deploy-kuttl |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/0dd52f162deb40f9bfc0b72ca455572e ❌ openstack-k8s-operators-content-provider FAILURE in 8m 18s |
|
/test dataplane-operator-build-deploy-kuttl |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/ecfe61289bf545ddacb131a1c437c145 ❌ openstack-k8s-operators-content-provider FAILURE in 8m 37s |
| - message: NodeSetBaremetalProvisionReady error occurred | ||
| reason: Error | ||
| severity: Error | ||
| status: "False" |
There was a problem hiding this comment.
I believe it would require a CI change to enable BMO_SETUP
There was a problem hiding this comment.
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/c16901eca16f44319f999420efaae951 ❌ openstack-k8s-operators-content-provider FAILURE in 8m 07s |
|
/test dataplane-operator-build-deploy-kuttl |
Signed-off-by: Fabricio Aguiar <[email protected]>
There was a problem hiding this comment.
I think this inverts the logic slighly on how we want to approach the samples.
IMO, it ought to be:
- minimal samples under config/samples that serve as kustomize base
- kustomize examples that kustomize the samples from 1
- A specific doc kustomize examples builds on the other examples
- kuttl tests use and docs both use what is generated from 3
This PR results in another top level CRs we have to maintain and continue to test. Instead, it should just all come from the base samples and kustomize examples.
Whether we end up documenting how to use kustomize, or a fully generated samples CRs is a separate question, as long as the source is kustomize for all of it.
1 and 2 are being addressed here: #764 I started this with docs to kuttl, for keeping the callouts, |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/4172ed356a90407b87a0fdf63f76631d ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 02s |
Signed-off-by: Fabricio Aguiar <[email protected]>
|
@fao89: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I realize that if we are taking preprovisioned/baremetal samples, they are already tested on zuul jobs, so we don't need to add kuttl tests for them. |
test inline samples with kuttl