Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable BMO_SETUP on kuttl tests #50180

Closed
wants to merge 1 commit into from
Closed

Enable BMO_SETUP on kuttl tests #50180

wants to merge 1 commit into from

Conversation

fao89
Copy link
Member

@fao89 fao89 commented Mar 25, 2024

No description provided.

@fao89 fao89 mentioned this pull request Mar 25, 2024
Closed
@openshift-ci openshift-ci bot requested review from abays and cjeanner March 25, 2024 10:52
@fao89
Copy link
Member Author

fao89 commented Mar 25, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl

1 similar comment
@fao89
Copy link
Member Author

fao89 commented Mar 25, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl

@fao89
Copy link
Member Author

fao89 commented Mar 25, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl

@fao89
Copy link
Member Author

fao89 commented Mar 25, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@fao89
Copy link
Member Author

fao89 commented Mar 25, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl

@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl

@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl

1 similar comment
@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl

@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl

1 similar comment
@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl

@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl

@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl

1 similar comment
@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl

@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl

@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl

@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 26, 2024
@fao89
Enable BMO_SETUP on kuttl tests
a98798a 
Signed-off-by: Fabricio Aguiar <[email protected]>
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 26, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@fao89: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy openstack-k8s-operators/dataplane-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl openstack-k8s-operators/dataplane-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-dataplane-operator-main-functional openstack-k8s-operators/dataplane-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-dataplane-operator-main-images openstack-k8s-operators/dataplane-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-dataplane-operator-main-precommit-check openstack-k8s-operators/dataplane-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl

1 similar comment
@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

@fao89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fao89
Copy link
Member Author

fao89 commented Mar 27, 2024

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 27, 2024
fao89
fao89 commented Mar 27, 2024
View reviewed changes
...nstack-k8s-operators/dataplane-operator/openstack-k8s-operators-dataplane-operator-main.yaml
Comment on lines +56 to +57
RUN echo -e '#!/bin/bash\necho sudo;' > /usr/local/bin/sudo && \
chmod +x /usr/local/bin/sudo
Copy link
Member Author

@fao89 fao89 Mar 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hack for ignoring sudo from https://github.com/metal3-io/baremetal-operator/blob/main/tools/deploy.sh

fao89
fao89 commented Mar 27, 2024
View reviewed changes
...nstack-k8s-operators/dataplane-operator/openstack-k8s-operators-dataplane-operator-main.yaml
RUN mv ./kubectl-kuttl /usr/local/bin
RUN yum install -y skopeo
ENV BMO_SETUP=true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

force bmo_setup: https://github.com/openstack-k8s-operators/install_yamls/blob/main/Makefile#L2111-L2114

rabi
rabi reviewed Mar 28, 2024
View reviewed changes
...nstack-k8s-operators/dataplane-operator/openstack-k8s-operators-dataplane-operator-main.yaml
RUN mv ./kubectl-kuttl /usr/local/bin
RUN yum install -y skopeo
ENV BMO_SETUP=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what we're trying here ,prow jobs use compact cluster and not crc. BMO should be already installed and running there...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that

@fao89 fao89 closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabi rabi rabi left review comments

@abays abays Awaiting requested review from abays

@cjeanner cjeanner Awaiting requested review from cjeanner

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fao89 @openshift-ci-robot @rabi