Update kustomize examples #764
Conversation
|
Skipping CI for Draft Pull Request. |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/b98b4dba17244f668c3bf46166dff9af ❌ dataplane-operator-docs-preview POST_FAILURE in 2m 48s |
|
@slagle @igallagh-redhat I moved the nova case into a kustomize example, |
|
For users familiar with kustomize docs, just sharing the |
|
i find this quite simple to understand https://github.com/openstack-k8s-operators/dataplane-operator/pull/769/files is less clear to me with regards to what that is adding |
|
i do like the approch of testing the example with kuttl and ectra and reusign the examples in the docs. perhaps you could expalin one vers the other approch in general. one thing i will say is i foudn the numeric callouts (1,2,3,4) ectra to be quite distracting and i would stongly prefer if we did no pullutate the examples like taht instead we should repeat the section taht we wnat to calll out aftre the exampel and describe it rather then anotating in line. |
|
|
||
| * Pre-provisioned nodes: | ||
|
|
||
| kustomize build preprovisioned > openstack-edpm.yaml | ||
| kustomize build preprovisioned_nodeset > openstack-edpm.yaml |
There was a problem hiding this comment.
i think we want to use oc kustomize in all the examples b/c that is how it comes packaged with the ocp client.
There was a problem hiding this comment.
also anywhere we are saying to modify the generated CR, can we use a kustomize example instead. For instance, steps 7 and 10.
| - libvirt | ||
| - *nova-cell-custom* | ||
| - telemetry | ||
| ---- |
There was a problem hiding this comment.
since this is dropped, where is it done in the kustomize (adding the custom service to the NodeSet)?
We need to think about how a user is going to combine the kustomize examples to generate the desired set of CRs. For example, what would be the process for using both examples/baremetal and examples/nova_cell_custom?
fao89
force-pushed
the
kustomizeupdate
branch
2 times, most recently
from
43d1cb6 to
574b9fa
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/f864f33b77684237a01f6d6727f0a4b4 ❌ dataplane-operator-docs-preview POST_FAILURE in 2m 51s |
fao89
force-pushed
the
kustomizeupdate
branch
3 times, most recently
from
30fb205 to
45f3444
Compare
| [compute] | ||
| cpu_shared_set = 2,6 | ||
| cpu_dedicated_set = 1,3,5,7 |
There was a problem hiding this comment.
@SeanMooney @gibizer is this a valid extra conf?
There was a problem hiding this comment.
If the edpm node has at least 8 cpus available then yes. If the node does not have that many cpus then nova-compute will fail to start
| [compute] | ||
| cpu_shared_set = 2,6 | ||
| cpu_dedicated_set = 1,3,5,7 |
There was a problem hiding this comment.
If the edpm node has at least 8 cpus available then yes. If the node does not have that many cpus then nova-compute will fail to start
| patches: | ||
| - target: | ||
| kind: OpenStackDataPlaneService | ||
| name: nova |
There was a problem hiding this comment.
Can we kustomize the nova service directly? I thought that dataplane-operator reconciles that automatically back to the stored sample in the repo
There was a problem hiding this comment.
kustomize will just use the service as a base, patch it and then create nova-cell-custom
There was a problem hiding this comment.
Right, so we're kustomizing the name in kustomization.yaml so it won't get overwritten during service reconcile.
I agree though, this is confusing as openstackdataplanenovaservice.yaml is just a copy of config/services/dataplane_v1beta1_openstackdataplaneservice_nova.yaml. Now we'd have to maintain that in 2 places with this change.
This would be more powerful if we could figure out how to run this example directly against config/services/dataplane_v1beta1_openstackdataplaneservice_nova.yaml, and then document for a user how they would do that, b/c that is the most likely workflow for a user.
When I tried this diff:
Mon Mar 25 04:26:58 (jslagle@teletran-1) [~/code/osp-ng/openstack-k8s-operators/dataplane-operator/examples/nova_cell_custom] (kustomizeupdate)$ git diff
diff --git a/examples/nova_cell_custom/kustomization.yaml b/examples/nova_cell_custom/kustomization.yaml
index cb20d6b..441c4f0 100644
--- a/examples/nova_cell_custom/kustomization.yaml
+++ b/examples/nova_cell_custom/kustomization.yaml
@@ -7,7 +7,7 @@ components:
- ../preprovisioned # for baremetal nodes, replace with baremetal
resources:
-- openstackdataplanenovaservice.yaml
+- ../../config/services/dataplane_v1beta1_openstackdataplaneservice_nova.yaml
configMapGenerator:
- name: nova-extra-config
oc kustomize results in an error:
Mon Mar 25 04:28:09 (jslagle@teletran-1) [~/code/osp-ng/openstack-k8s-operators/dataplane-operator/examples/nova_cell_custom] (kustomizeupdate)$ oc kustomize .
error: accumulating resources: accumulation err='accumulating resources from '../../config/services/dataplane_v1beta1_openstackdataplaneservice_nova.yaml': security; file '/home/jslagle/code/osp-ng/openstack-k8s-operators/dataplane-operator/config/services/dataplane_v1beta1_openstackdataplaneservice_nova.yaml' is not in or below '/home/jslagle/code/osp-ng/openstack-k8s-operators/dataplane-operator/examples/nova_cell_custom'': must build at directory: '/home/jslagle/code/osp-ng/openstack-k8s-operators/dataplane-operator/config/services/dataplane_v1beta1_openstackdataplaneservice_nova.yaml': file is not directory
Is there a way we could make this work?
There was a problem hiding this comment.
Ok, so this works with the diff above:
oc kustomize --load-restrictor LoadRestrictionsNone .
I think we need to get rid of the file duplication and document it this way, unless there are other options?
There was a problem hiding this comment.
I removed the duplication of the nodeset and deployment samples, now all the kustomize examples needs this, I started this: openstack-k8s-operators/install_yamls#787
|
/test dataplane-operator-build-deploy-kuttl |
1 similar comment
|
/test dataplane-operator-build-deploy-kuttl |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/af591cc2051946919a6f0bee3d6c1a8a ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 46s |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/4c680c2d2550400c873a37a16eba611c ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 56m 51s |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/bca36f04245b48de98be45befca74322 ❌ openstack-k8s-operators-content-provider FAILURE in 17m 57s |
fao89
force-pushed
the
kustomizeupdate
branch
2 times, most recently
from
291eec0 to
0278223
Compare
|
pre-commit fix: openshift/release#50256 |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/62a78d66f8d547eda35c8a190ca72fbb ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 53m 29s |
|
/test precommit-check |
fao89
force-pushed
the
kustomizeupdate
branch
2 times, most recently
from
8603e1f to
f3d3a67
Compare
|
needs: openshift/release#50266 |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/bea1c7c1839f471383d19b751d97bb36 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 13m 02s |
|
/test precommit-check |
|
recheck |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/a0e461c9fbc64ec0ab9159b213f6d595 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 35m 14s |
|
recheck unreachable |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/775f6394bb4148908e7e38133f8cd91f ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 01m 10s |
|
recheck |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/b0aeea0b42a2471dae53d82caac128a2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 22m 31s |
Renaming values to make easier to compose i.e. replace components with other scenarios Signed-off-by: Fabricio Aguiar <[email protected]>
Signed-off-by: Fabricio Aguiar <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fao89, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 7f01dea
into
openstack-k8s-operators:main
No description provided.