Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add oc and yq to dataplane pre-commit #50256

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Add oc and yq to dataplane pre-commit #50256

merged 1 commit into from
Mar 26, 2024

Conversation

fao89
Copy link
Member

@fao89 fao89 commented Mar 26, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from fultonj and slagle March 26, 2024 17:22
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl

@fao89 fao89 mentioned this pull request Mar 26, 2024
Merged
@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl

@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-precommit-check

@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-precommit-check

1 similar comment
@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-precommit-check

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@fao89: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy openstack-k8s-operators/dataplane-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl openstack-k8s-operators/dataplane-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-dataplane-operator-main-functional openstack-k8s-operators/dataplane-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-dataplane-operator-main-images openstack-k8s-operators/dataplane-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-dataplane-operator-main-precommit-check openstack-k8s-operators/dataplane-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-precommit-check

2 similar comments
@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-precommit-check

@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-dataplane-operator-main-precommit-check

@fao89
Copy link
Member Author

fao89 commented Mar 26, 2024

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 26, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fccd8f2 into openshift:master Mar 26, 2024
17 checks passed
BradLugo pushed a commit to BradLugo/openshift-release that referenced this pull request Jun 13, 2024
@fao89 @BradLugo
Add oc and yq to dataplane pre-commit (openshift#50256)
70fa6a1 
Signed-off-by: Fabricio Aguiar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slagle slagle slagle approved these changes

@fultonj fultonj Awaiting requested review from fultonj

Assignees

@slagle slagle

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fao89 @openshift-ci-robot @slagle